Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Color by CDS" for BED12 features #4773

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Fix "Color by CDS" for BED12 features #4773

merged 2 commits into from
Jan 17, 2025

Conversation

cmdcolin
Copy link
Collaborator

Fixes #4772

This adds a phase field to features generated in BED12

The SVG Box renderer uses the existence of the "phase" field to determine whether to color by CDS

Specifically this check

colorByCDS &&
featureType === 'CDS' &&
featureStrand !== undefined &&
featurePhase !== undefined
) {
const frame = getFrame(

@cmdcolin
Copy link
Collaborator Author

potentially could remove the check for phase!==undefined as an alternative to this but might just keep for now

@cmdcolin cmdcolin merged commit ba16ba9 into main Jan 17, 2025
4 checks passed
@cmdcolin cmdcolin deleted the fix_cds_phase_bed12 branch January 17, 2025 14:03
@cmdcolin cmdcolin added the bug Something isn't working label Jan 17, 2025
@cmdcolin cmdcolin changed the title Fix Color by CDS for BED12 features Fix "Color by CDS" for BED12 features Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BED12 features don't color by CDS
1 participant