Skip to content

Commit

Permalink
FileDiff: fix file descriptor leak (#885)
Browse files Browse the repository at this point in the history
When a FileDiff tab starts it creates 6 pipes via CachedSequenceMatcher.
They are never released. Eventually the process runs out of file
descriptors (typically 1024 on linux).

Introduced in commit 8ed5bef Sat Mar 20 09:37:50 2021

     filediff, matchers.helpers: Improve matcher process clean up (#565)
  • Loading branch information
Alan Suran committed Jan 31, 2025
1 parent a17c847 commit 20dc8d4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions meld/filediff.py
Original file line number Diff line number Diff line change
Expand Up @@ -1303,6 +1303,7 @@ def on_delete_event(self):

try:
self._cached_match.stop()
self._cached_match = None
except Exception:
# Ignore any cross-process exceptions that happen when
# shutting down our matcher process.
Expand Down

0 comments on commit 20dc8d4

Please sign in to comment.