Fix Issue google#211 by unwrapping data after checking for an error. (g…

…oogle#213) Signed-off-by: campionfellin <[email protected]>
GPCsolutions · Jun 6, 2018 · 88f8e33 · 88f8e33
1 parent d8a017d
commit 88f8e33
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/files.ts b/src/files.ts
@@ -141,12 +141,13 @@ export async function fetchProject(scriptId: string, rootDir = '', versionNumber
   script.projects.getContent({
     scriptId,
     versionNumber,
-  }, {}, (error: any, { data }: any) => {
+  }, {}, (error: any, res: any) => {
     spinner.stop(true);
     if (error) {
       if (error.statusCode === 404) return logError(null, ERROR.SCRIPT_ID_INCORRECT(scriptId));
       return logError(error, ERROR.SCRIPT_ID);
     } else {
+      const data = res.data;
       if (!data.files) {
         return logError(null, ERROR.SCRIPT_ID_INCORRECT(scriptId));
       }

diff --git a/tests/test.ts b/tests/test.ts
@@ -80,6 +80,13 @@ describe.skip('Test clasp clone <scriptId> function', () => {
     expect(result.stdout).to.contain('files.');
     expect(result.status).to.equal(0);
   });
+  it('should give an error on a non-existing project', () => {
+    const result = spawnSync(
+      'clasp', ['clone', 'non-existing-project'], { encoding: 'utf8' },
+    );
+    expect(result.stderr).to.contain('> Did you provide the correct scriptId?');
+    expect(result.status).to.equal(1);
+  });
 });
 
 describe.skip('Test clasp pull function', () => {