Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-4173 Morphic QSS Solution #825

Closed
wants to merge 1 commit into from
Closed

GPII-4173 Morphic QSS Solution #825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 87 additions & 0 deletions testData/solutions/win32.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16206,5 +16206,92 @@
"type": "gpii.deviceReporter.alwaysInstalled"
}
]
},
"net.gpii.morphic": {
"name": "Morphic",
"contexts": {
"OS": [
{
"id": "win32",
"version": ">=5.0"
}
]
},
"settingsHandlers": {
"configure": {
"type": "gpii.settingsHandlers.noSettings",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this actually use the WebSockets settings handler?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this probably uses a settings handler that doesn't quite exist yet, which would include whatever code in the gpii-app would re-arrange it's UI when a key-in occurs and these new settings come down from the flowManager.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sgithens, actually, this settings handler already exists (see https://github.com/GPII/universal/blob/master/documentation/BrowserChannel.md) and is what UIO+ uses to receive settings from the local flowManager (see https://github.com/GPII/universal/blob/master/testData/solutions/win32.json5#L12421). You can follow the UIO+ example for the Morphic QSS solution registry entry.
Regarding the gpii-app side, I guess that we should consult HA about the best way to make it happen.

"liveness": "live",
"supportedSettings": {
"qss.showQssOnStart": {
"schema": {
"title": "Show QSS on Start",
"description": "Determines if the QSS will be shown automatically on Morphic's startup",
"type": "boolean",
"default": false
}
},
"qss.alwaysUseChrome": {
"schema": {
"title": "Always Use Chrome",
"description": "Determines if Morphic should always use Chrome for launching external services.",
"type": "boolean",
"default": false
}
},
"qss.buttonList": {
"schema": {
"title": "QSS Button List",
"description": "List of the desired list of buttons shown in QSS",
"type": "array",
"default": [
"language",
"translate-tools",
"screen-zoom",
"text-zoom",
"screen-capture",
"office-simplification",
"high-contrast",
"read-aloud",
"volume",
"launch-documorph",
"cloud-folder-open",
"usb-open",
"separator-visible",
"service-more",
"service-save",
"service-undo",
"service-dummy",
"service-reset-all",
"service-close"
]
}
},
"qss.closeQssOnClickOutside": {
"schema": {
"title": "Hide QSS on Outside Click",
"description": "Whether to hide the QSS when a user clicks outside of it",
"type": "boolean",
"default": true
}
},
"qss.disableRestartWarning": {
"schema": {
"title": "Disable restart warnings",
"description": "Whether to disable the displaying of notifications that suggest some applications may need to be restarted in order for a changed setting to be fully applied. An example for such setting is `Language`. If set to `true`, such notifications will NOT be displayed.",
"type": "boolean",
"default": true
}
},
"qss.openQssShortcut": {
"schema": {
"title": "Open QSS Shortcut",
"description": "The shortcut that open the QSS. For posible values refer to: https://electronjs.org/docs/api/accelerator",
"type": "string",
"default": "Shift+Ctrl+AltOrOption+SuperOrCmd+M"
}
}
}
}
}
}
}