Fix visitPHINode for PatchPeepholeOpt #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test summary for commit b083d4fDriver commits used in build
CTS tests (Failed: 0/192520)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8Ubuntu 20.04, Gfx103 |
LLJJDD
force-pushed
the
fix_peephole_opt_for_phi
branch
2 times, most recently
from
a6225e2 to
7e70df6
Compare
|
Thanks for adding the test, that's really helpful to know the breaking case. The patch itself looks good. But I think it would be better to further investigate why this optimization was there. Currently we check against most known |
jiaolu
approved these changes
Dec 23, 2020
LLJJDD
force-pushed
the
fix_peephole_opt_for_phi
branch
from
7e70df6 to
4e893ba
Compare
|
retest this please |
PHI with incoming value that may read from memory should not be optimized, because whether the memory content is changed is unknown, the same load may produce different values in each incoming block. Also add a lgc test for it.
|
retest this please |
LLJJDD
force-pushed
the
fix_peephole_opt_for_phi
branch
from
4e893ba to
d69b9e1
Compare
|
retest this please |
Test summary for commit d69b9e1Driver commits used in build
CTS tests (Failed: 0/222489)
Rhel 8.2, Gfx10Ubuntu 18.04, Gfx9Ubuntu 20.04, Gfx8Ubuntu 20.04, Gfx103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHI with incoming value that may read from memory should not be optimized, because whether the memory content is changed is unknown, the same load may produce different values in each incoming block.