Move LowerGpuRt into LGC #2852
Merged
Move LowerGpuRt into LGC #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With some tweak to adapt the change.
Test summary for commit d15e7f2CTS tests (Failed: 1645/138443)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
|
retest this please |
|
Some comments, apart from that it looks good. Are the Jenkins / CTS failures related? |
The resource mapping seems to be messed up when using CreateReadBuiltInInput out of builder replayer.
Yes, hopefully my latest commit fixes them. |
Test summary for commit b8614d2CTS tests (Failed: 0/138378)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
| @@ -342,6 +342,10 @@ Options PipelineContext::computePipelineOptions() const { | |||
| options.enablePrimGeneratedQuery = getPipelineOptions()->enablePrimGeneratedQuery; | |||
| options.enableFragColor = getPipelineOptions()->enableFragColor; | |||
|
|
|||
| options.rtBoxSortHeuristicMode = m_rtState.boxSortHeuristicMode; | |||
| options.rtStaticPipelineFlags = m_rtState.staticPipelineFlags; | |||
| options.rtTriCompressMode = m_rtState.triCompressMode; | |||
There was a problem hiding this comment.
Do you need to default-initialize useGpurt here as well?
There was a problem hiding this comment.
The = {} initialization at the top should take care of that, right?
There was a problem hiding this comment.
Yes. My question is based on the fact that we initialize other members with a constant value here as well, so it is merely a question about coding style.
There was a problem hiding this comment.
I think we don't need to because it is always false (unknown) at here.
nhaehnle
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Following yesterday's discussion, luckily @mbrkusanin is going to work on moving the descriptor load lowering out of the builder replayer. Once that's done, it should be possible to remove this workaround and move LowerGpuRt to after the BuilderReplayer and in fact after LowerRaytracingPipeline, where it should be in the long run.
Maybe you can double-check Thomas' question, but apart from that this LGTM.
| @@ -342,6 +342,10 @@ Options PipelineContext::computePipelineOptions() const { | |||
| options.enablePrimGeneratedQuery = getPipelineOptions()->enablePrimGeneratedQuery; | |||
| options.enableFragColor = getPipelineOptions()->enableFragColor; | |||
|
|
|||
| options.rtBoxSortHeuristicMode = m_rtState.boxSortHeuristicMode; | |||
| options.rtStaticPipelineFlags = m_rtState.staticPipelineFlags; | |||
| options.rtTriCompressMode = m_rtState.triCompressMode; | |||
There was a problem hiding this comment.
The = {} initialization at the top should take care of that, right?
qiaojbao
pushed a commit
that referenced
this pull request
Jan 2, 2024
With some tweak to adapt the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some tweak to adapt the change.