Remove dump CFG support from legacy pass manager #2855
Merged
+3
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhaehnle
previously approved these changes
Nov 29, 2023
Upstream CFGPrinter support is being updated to remove legacy pass manager support. LGC only supports this option in legacy pass manager so removing the option entirely. LGC now mostly uses the new pass manager, so the option is of limited use and can only be enabled for backend passes anyway.
dstutt
force-pushed
the
remove-dump-cfg
branch
from
344e92f to
de3170d
Compare
trenouf
approved these changes
Nov 29, 2023
Test summary for commit 344e92fCTS tests (Failed: 0/138378)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Test summary for commit de3170dCTS tests (Failed: 0/138378)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream CFGPrinter support is being updated to remove legacy pass manager support.
LGC only supports this option in legacy pass manager so removing the option entirely. LGC now mostly uses the new pass manager, so the option is of limited use and can only be enabled for backend passes anyway.