Make tests compatible with upstream llvm #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the new disjoint flag on `or`s, which was recently added upstream.
Test summary for commit 133b7a5CTS tests (Failed: 0/138443)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Test summary for commit 2099fa8CTS tests (Failed: 0/138378)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
nhaehnle
approved these changes
Dec 5, 2023
dstutt
reviewed
Dec 5, 2023
| @@ -21,7 +21,7 @@ void main() | |||
| // CHECK-NEXT: [[TMP0:%.*]] = call i64 @llvm.amdgcn.s.getpc() | |||
| // CHECK-NEXT: [[TMP1:%.*]] = and i64 [[TMP0]], -4294967296 | |||
| // CHECK-NEXT: [[TMP2:%.*]] = zext i32 [[USERDATA0]] to i64 | |||
| // CHECK-NEXT: [[TMP3:%.*]] = or i64 [[TMP1]], [[TMP2]] | |||
| // CHECK-NEXT: [[TMP3:%.*]] = or {{(disjoint )?}}i64 [[TMP1]], [[TMP2]] | |||
There was a problem hiding this comment.
This test has auto-generated checks - presumably the optional disjoint will get changed if that's run?
There was a problem hiding this comment.
Yeah, once llvm is updated and someone regenerates the test, these will be made permanent :)
| @@ -85,7 +85,7 @@ attribute[0].offset = 0 | |||
| ; SHADERTEST-NEXT: [[DOTI1:%.*]] = fptosi float [[TMP19]] to i32 | |||
| ; SHADERTEST-NEXT: [[TMP12:%.*]] = and i64 [[TMP11]], -4294967296 | |||
| ; SHADERTEST-NEXT: [[TMP13:%.*]] = zext i32 [[DESCTABLE0:%.*]] to i64 | |||
| ; SHADERTEST-NEXT: [[TMP14:%.*]] = or i64 [[TMP12]], [[TMP13]] | |||
| ; SHADERTEST-NEXT: [[TMP14:%.*]] = or {{(disjoint )?}}i64 [[TMP12]], [[TMP13]] | |||
jayfoad
approved these changes
Dec 5, 2023
dstutt
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the new disjoint flag on
ors, which was recently added upstream.