Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lgc: fix translation of maxThreadGroupsPerComputeUnit #2866

Merged
merged 1 commit into from
Dec 7, 2023
Merged

lgc: fix translation of maxThreadGroupsPerComputeUnit #2866

merged 1 commit into from
Dec 7, 2023

Conversation

nhaehnle
Copy link
Member

@nhaehnle nhaehnle commented Dec 5, 2023

Found by inspection.

LLVM's occupancy code uses "EU" to mean "SIMD".

@nhaehnle
lgc: fix translation of maxThreadGroupsPerComputeUnit
ed3dcb7 
Found by inspection.

LLVM's occupancy code uses "EU" to mean "SIMD".
@nhaehnle nhaehnle requested a review from a team as a code owner December 5, 2023 08:22
@amdvlk-admin
Copy link

Test summary for commit ed3dcb7

CTS tests (Failed: 0/138378)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35163/69163 (50.8%)
    • Failed: 0/69163 (0.0%)
    • Not Supported: 34000/69163 (49.2%)
    • Warnings: 0/69163 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35241/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33974/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@nhaehnle nhaehnle merged commit 69594c2 into GPUOpen-Drivers:dev Dec 7, 2023
9 checks passed
@nhaehnle nhaehnle deleted the pub-maxtgpercu branch December 7, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flakebi Flakebi Flakebi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nhaehnle @amdvlk-admin @Flakebi