Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPV_KHR_non_semantic_info support #479

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Add SPV_KHR_non_semantic_info support #479

merged 1 commit into from
Feb 25, 2020

Conversation

LLJJDD
Copy link
Contributor

@LLJJDD LLJJDD commented Feb 21, 2020

We do not actually proccess the extension, instead, just ignore the instructions and let parser handle them silently.

nhaehnle
nhaehnle approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. ok to test

@LLJJDD LLJJDD force-pushed the SPV_KHR_non_semantic_info branch from 4bfeafb to 311d322 Compare February 24, 2020 06:03
@LLJJDD LLJJDD force-pushed the SPV_KHR_non_semantic_info branch from 311d322 to f1a548d Compare February 24, 2020 06:09
@amdvlk-admin
Copy link

Test summary for commit 311d322

Driver commits used in build
  • CWPACK: amd-master b601c88aeca7a7b08becb3d32709de383c8ee428
  • METROHASH: amd-master 2b6fee002db6cc92345b02aeee963ebaaf4c0e2f
  • PAL: dev 45f531beaf2c2b0bc2272e63a2da0022f1b07ccf
  • SPVGEN: dev 81f6794e048edd31d8c03343b9ed10dd4c0331ca
  • XGL: dev 8024f27f9457e3235bf4fcde0d2879bbaae7b0f2
  • LLVM-PROJECT: amd-gfx-gpuopen-dev a163b38723cbc05f3014d4eaa1936c82bbfbf3ea
ShaderDB test
  • Passed: 945/945 (100.0%)
  • Failed: 0/945 (0.0%)
CTS tests (built with branch Vulkan-CTS-1.1.2.3-cherry-picks)
    Rhel 7.6, Vega10
    • Passed: 2155/2156 (100.0%)
    • Failed: 1/2156 (0.0%)

      Failures:

      FAILURE: dEQP-VK.api.object_management.multithreaded_shared_resources.compute_pipeline
Stack trace: Timeout or crahsed

    Ubuntu 18.04, Navi10
    • Passed: 65463/65463 (100.0%)
    • Failed: 0/65463 (0.0%)
    Ubuntu 18.04, Ellesmere
    • Passed: 65431/65431 (100.0%)
    • Failed: 0/65431 (0.0%)

@amdvlk-admin
Copy link

Test summary for commit f1a548d

Driver commits used in build
  • CWPACK: amd-master b601c88aeca7a7b08becb3d32709de383c8ee428
  • METROHASH: amd-master 2b6fee002db6cc92345b02aeee963ebaaf4c0e2f
  • PAL: dev 45f531beaf2c2b0bc2272e63a2da0022f1b07ccf
  • SPVGEN: dev 81f6794e048edd31d8c03343b9ed10dd4c0331ca
  • XGL: dev 8024f27f9457e3235bf4fcde0d2879bbaae7b0f2
  • LLVM-PROJECT: amd-gfx-gpuopen-dev a163b38723cbc05f3014d4eaa1936c82bbfbf3ea
ShaderDB test
  • Passed: 945/945 (100.0%)
  • Failed: 0/945 (0.0%)
CTS tests (built with branch Vulkan-CTS-1.1.2.3-cherry-picks)
    Rhel 7.6, Vega10
    • Passed: 65463/65463 (100.0%)
    • Failed: 0/65463 (0.0%)
    Ubuntu 18.04, Navi10
    • Passed: 65463/65463 (100.0%)
    • Failed: 0/65463 (0.0%)
    Ubuntu 18.04, Ellesmere
    • Passed: 65431/65431 (100.0%)
    • Failed: 0/65431 (0.0%)

@JaxLinAMD JaxLinAMD merged commit 9928bfe into GPUOpen-Drivers:dev Feb 25, 2020
nhaehnle pushed a commit to nhaehnle/llpc that referenced this pull request Apr 7, 2020
SWDEV-141535 - [LLPC][PR479] Add SPV_KHR_non_semantic_info support
5001fed 
Pull Request: GPUOpen-Drivers#479

OVS = http://ocltc.amd.com:8111/viewModification.html?modId=132089&personal=true&buildTypeId=&tab=vcsModificationFiles

git-pf-change: stg@2075159
jaebaek pushed a commit to jaebaek/llpc that referenced this pull request Nov 24, 2020
@copybara-github
Copybara import of LLPC (https://github.com/GPUOpen-Drivers/llpc)
5a01a74 
  - 8e17e63 Add a space in error messages for readability by Jay Foad <[email protected]>
  - 32e33e8 Implement new amdllpc command line option -emit-llvm-bc by Jay Foad <[email protected]>
  - 9928bfe Merge pull request GPUOpen-Drivers#479 from LLJJDD/SPV_KHR_non_semantic_... by JaxLinAMD <[email protected]>
  - b9c349d Add int64 image atomics support. by Rex Xu <[email protected]>

GitOrigin-RevId: 8e17e63
Change-Id: I9350963ac20615b7b0099a0013fe39b2bdfdc1f7
@LLJJDD LLJJDD deleted the SPV_KHR_non_semantic_info branch April 10, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhar kuhar kuhar left review comments

@trenouf trenouf trenouf left review comments

@nhaehnle nhaehnle nhaehnle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LLJJDD @amdvlk-admin @nhaehnle @kuhar @trenouf @JaxLinAMD