Convert to server-side query: admin panel -> edit user group -> search users

[echappen]

Pull Request Checklist

Closes #167

Changelog Entry

Description

For admin panel -> users -> groups -> edit user group -> search users:

• Removes typeahead search in favor of server-side search
• This will make user search more resilient at scale, as the users list was previously retrieving every single user in the database
• Also capitalizes other search button for general users list, to be consistent with the casing of other buttons throughout the app

How to test

1. Log in as an admin
2. Go to admin panel
3. Click Groups, then click the name of a user group
4. In the Edit User group modal, select the Users tab
5. Try searching for a non-admin user (admins are filtered in keeping with existing functionality)

Changed

• users search now uses a button

Removed

• Removed client-side filtering of users in favor of server-side query

Security

• Note: No change to the API query method itself, we're using the same one as before

Breaking Changes

• None known

---

Additional Information

I think having the search button as text is important for accessibility. However, replacing the magnifying glass icon with a button makes this top area of the modal a little awkward with the current design patterns. I think the awkwardness comes from having no borders around elements. I'm very open to any thoughts on how to make this UI better. I've included some potential design options as screenshots below

Screenshots or Videos

This is the original modal:

---

These are design options I considered:

---

This is the option I went with that's currently coded:

[echappen]

@actuallyjenn Tagging you on this for a UI review. See PR description for details.

[jfredrickson]

LGTM in terms of functionality/code, will defer to @actuallyjenn on the UI question. IMO, agreed that this app's UI has some delineation awkwardness.

[actuallyjenn]

looks good to me from a UI perspective. we'll have to go back and figure out how to handle some of these elements better later but appreciate the different options you included eleni! i'm thinking we'll probably add borders in the future.

[echappen]

Thank you both!