Setup Dev Deployment Infrastructure #23
Conversation
|
|
||
| ## Decision | ||
|
|
||
| We will use Celery as the task queue for this project. |
There was a problem hiding this comment.
It'd be help to have a brief description of "why Celery" (vs alternatives) in here also.
nad_ch/config.py
Outdated
| STORAGE_PATH = os.getenv("STORAGE_PATH") | ||
| DATABASE_URL_LOCAL = os.getenv("DATABASE_URL_LOCAL") | ||
| QUEUE_BROKER_URL_LOCAL = os.getenv("QUEUE_BROKER_URL_LOCAL") | ||
| QUEUE_BACKEND_URL_LOCAL = os.getenv("QUEUE_BACKEND_URL_LOCAL") |
There was a problem hiding this comment.
Instead of separate variables for, eg DATABASE_URL_LOCAL and DATABASE_URL, perhaps DATABASE_URL could be defined inside an if condition for these kind of cases?
There was a problem hiding this comment.
There could perhaps also be separate modules for each environment. Here's one way to do that: https://github.com/18F/FAC-Distiller/blob/main/distiller/settings/__init__.py
There was a problem hiding this comment.
This approach is much, much better--thank you for providing an example.
| self.app.worker_main(argv=["worker", "--loglevel=info"]) | ||
|
|
||
|
|
||
| class LocalTaskQueue: |
There was a problem hiding this comment.
This looks great! I could also see maybe wanting an in-memory broker for unit tests.
Changes include:
manifest-dev.ymlApplicationContextSessionobject on instantiation: this makes it easier to set up a fakeSessionfor testing