-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Submission Reports Feature #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - sorry for the delay
): | ||
return DataSubmissionReport( | ||
overview=DataSubmissionReportOverview(feature_count=1) | ||
) | ||
|
||
app_context._task_queue = CustomMockTestTaskQueue() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future thought - it might be helpful to have a way to provide a mock implementation to create_app_context
(or maybe create_test_app_context
- if this was done often.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, we will almost certainly need to do this sort of mocking a number of times.
Co-authored-by: Daniel Naab <[email protected]>
Changes
Fixes
Future Considerations