-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud.gov login integration #35
Conversation
USER appuser | ||
CMD ["/bin/sh", "./scripts/start_local.sh"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure on current best practices, but you could speed up the container start-up by precompiling the bytecode as the root user. https://kence.org/2022/05/23/python-bytecode-and-read-only-containers/
|
||
new_user = User( | ||
email=email, | ||
username=email.split("@")[0], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a separate user name? I might vote for omitting it. Or maybe this is a "display name"?
Also, I think this isn't a problem with the way the function is currently called, but I think the email address should probably be validated here.
Changes
Considerations