Add column mapping and data reader #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sb-2011
force-pushed
the
column-mapping
branch
3 times, most recently
from
8f25ed3 to
ad6a486
Compare
akuny
approved these changes
Feb 22, 2024
.gitignore
Outdated
|
|
||
| # Pre-commit Config | ||
| .pre-commit-config.yaml |
There was a problem hiding this comment.
If you've set up git hooks, this would be good to have under version control.
| class DataReader(object): | ||
| def __init__(self, config_name: Optional[str] = None) -> None: | ||
| self.config_name = config_name | ||
| self.default_config_path = "nad_ch/application/nad_column_maps/default.yaml" |
There was a problem hiding this comment.
This approach seems reasonable to me in the context of an MVP, but we might want to keep in mind the option of having the Storage infrastructure class handle configuration file storage and retrieval at the behest of the application layer, as opposed to having the DataReader class know about the filesystem.
That being said, let's roll with whatever is going to get us up and running quickly and keep an eye on it, imo. @danielnaab please chime in if you have other thoughts.
sb-2011
force-pushed
the
column-mapping
branch
from
ad6a486 to
4e9150f
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to introduce the first iteration of column mapping (crosswalk) logic to the application as well as the data reader that will read the different forms of geospatial data from data providers.