Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column mapping and data reader #36

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Add column mapping and data reader #36

merged 1 commit into from
Feb 23, 2024

Conversation

sb-2011
Copy link
Collaborator

@sb-2011 sb-2011 commented Feb 22, 2024

The purpose of this PR is to introduce the first iteration of column mapping (crosswalk) logic to the application as well as the data reader that will read the different forms of geospatial data from data providers.

@sb-2011 sb-2011 requested a review from akuny February 22, 2024 16:17
@sb-2011 sb-2011 force-pushed the column-mapping branch 3 times, most recently from 8f25ed3 to ad6a486 Compare February 22, 2024 16:40
Copy link
Collaborator

@akuny akuny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a solid step in the right direction to me!

.gitignore Outdated

# Pre-commit Config
.pre-commit-config.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you've set up git hooks, this would be good to have under version control.

class DataReader(object):
def __init__(self, config_name: Optional[str] = None) -> None:
self.config_name = config_name
self.default_config_path = "nad_ch/application/nad_column_maps/default.yaml"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach seems reasonable to me in the context of an MVP, but we might want to keep in mind the option of having the Storage infrastructure class handle configuration file storage and retrieval at the behest of the application layer, as opposed to having the DataReader class know about the filesystem.

That being said, let's roll with whatever is going to get us up and running quickly and keep an eye on it, imo. @danielnaab please chime in if you have other thoughts.

@sb-2011 sb-2011 merged commit 3d9f1db into main Feb 23, 2024
1 check passed
@sb-2011 sb-2011 deleted the column-mapping branch February 23, 2024 16:52
@sb-2011 sb-2011 mentioned this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants