Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config map and validation changes #41

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Config map and validation changes #41

merged 1 commit into from
Mar 7, 2024

Conversation

sb-2011
Copy link
Contributor

@sb-2011 sb-2011 commented Mar 7, 2024 •
edited
Loading

  • validation in conjunction with dtos modified to handle submitted data in batches
  • changes made to entities, database models, & migration added
  • unit tests added for validation logic and config validation

TODO:

  • create tests for the repositories' methods/queries
  • create tests for celery task(s)

@sb-2011 sb-2011 requested a review from akuny March 7, 2024 17:03
akuny
akuny approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@akuny akuny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sb-2011 sb-2011 merged commit 24eacc3 into main Mar 7, 2024
1 check passed
@sb-2011 sb-2011 deleted the config-map-and-validation-changes branch March 7, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuny akuny akuny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sb-2011 @akuny