203 - adding program logos to the cards on the home page #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if we wanted to include any other logos before push to production |
|
Based on our discusion, PRA Guide has an icon that doesn't appear to be a logo, and both PRA Guide and Site Scanning live under Digital.gov so should get an OK from them. Census xD would be the wildcard, and perhaps @willcahoe might know who to reach out to for an OK. They're using a PNG not an SVG (https://www.xd.gov/assets/img/xd-logo.png) @jonathanbobel if that matters to you? |
jonadecker
previously approved these changes
Sep 11, 2024
…3-add-program-logos-to-featured-products # Conflicts: # _data/assetPaths.json # pages/homepage.md
|
Changes to SS LGTM @jonathanbobel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating home page to have program logos in the card area
Reference: #189
PR Preview