Merge pull request #4273 from GSA-TTS/main

GSA-TTS · Sep 11, 2024 · 8e4bf31 · 8e4bf31
2 parents 317ba4b + 5b73f02
commit 8e4bf31
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.github/ISSUE_TEMPLATE/offboarding.md b/.github/ISSUE_TEMPLATE/offboarding.md
@@ -16,7 +16,8 @@ assignees: ''
 - [ ] Remove from the private channels #oros-fac-private and #fac-helpdesk in Slack (“/remove @[person]”)
 - [ ] Remove from active Figma projects
 - [ ] Remove from Mural
-- [ ] Remove from Zendesk 
+- [ ] Remove from Zendesk [here](https://fac-gov.zendesk.com/admin/people/team/members).
+- [ ] Remove from the list of staff users in the Django Admin app [here](https://app.fac.gov/admin/users/staffuser/).
 - [ ] Check for and remove admin access in the FAC application: this may include designated permissions and/or checked-in API  access ([for example](https://github.com/GSA-TTS/FAC/blob/fb0e7bdf1cb1807291e6b6eef068e97b4574078c/backend/support/api/admin_api_v1_1_0/create_access_tables.sql#L21))
 
 ## For GitHub contributors

diff --git a/.github/ISSUE_TEMPLATE/onboarding.md b/.github/ISSUE_TEMPLATE/onboarding.md
@@ -86,3 +86,7 @@ Note: If you're not able to do any of these yourself, you're still responsible f
 - [ ] Make them Owner of [the various Google Groups in the project README](https://docs.google.com/document/d/1g8nYqYS_ifFlZB-DBgfeSoJRMB__EqWsmLnacyk-bDI/edit#heading=h.81zynabayrrg)
 - [ ] Add them to [the FAC-admins team in GitHub](https://github.com/orgs/GSA-TTS/teams/fac-admins/members) and make them a Maintainer.
 - [ ] Also give them the `Maintainer` role in [the FAC-team team in GitHub](https://github.com/orgs/GSA-TTS/teams/fac-team/members).
+
+**For helpdesk, also...**
+- [ ] Add them to the list of staff users for [Django Admin](https://app.fac.gov/admin/users/staffuser/).
+- [ ] Give them access to the [Help Desk](https://fac-gov.zendesk.com/admin/people/team/members) as a team member.
diff --git a/backend/audit/views/manage_submission_access.py b/backend/audit/views/manage_submission_access.py
@@ -144,8 +144,8 @@ def get_user_role_management_context(self, sac):
             "friendly_role": None,
             "auditee_uei": sac.general_information["auditee_uei"],
             "auditee_name": sac.general_information.get("auditee_name"),
-            "certifier_name": None,
-            "email": None,
+            "certifier_name": "",
+            "email": "",
             "report_id": sac.report_id,
             "errors": [],
         }