Skip to content

Commit

Permalink
Merge pull request #3569 from GSA-TTS/main
Browse files Browse the repository at this point in the history
2023-03-27 main -> prod
  • Loading branch information
sambodeme authored Mar 27, 2024
2 parents 9c9f30e + e864608 commit 8f4ba65
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion backend/audit/intakelib/intermediate_representation.py
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ def extract_workbook_as_ir(file):
process_destination(dn, title, coord, sheets_by_name, workbook)
except StopIteration:
logger.info(f"No destinations found for {named_range_name}.")
raise_modified_workbook(WORKBOOK_MODIFIED_ERROR)
# raise_modified_workbook(WORKBOOK_MODIFIED_ERROR)

# Build the IR, which is a list of sheets.
sheets = []
Expand Down
4 changes: 4 additions & 0 deletions backend/audit/test_intakelib.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import unittest
from django.test import SimpleTestCase
from copy import deepcopy
from audit.intakelib.intermediate_representation import (
Expand Down Expand Up @@ -144,6 +145,9 @@ def test_extract_with_ref_error(self, mock_open_workbook):
with self.assertRaises(ValidationError):
extract_workbook_as_ir("dummy_file_with_ref_error")

@unittest.skip(
"Skipping this test as we have turned off check for no destination found in extract_workbook_as_ir."
)
@patch("audit.intakelib.intermediate_representation._open_workbook")
def test_no_destination_found(self, mock_open_workbook):
"""Test handling of a workbook with no destinations found for a named range."""
Expand Down

0 comments on commit 8f4ba65

Please sign in to comment.