2023-10-18 main -> prod

[danswick]

• Fix cog/over nulls issue and add migration.
• Create re-dissemination task.
• Fix missing fields in admin view.

[github-actions]

Terraform plan for production

Plan: 0 to add, 1 to change, 0 to destroy.

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.production.module.https-proxy.cloudfoundry_app.egress_app will be updated in-place
  ~ resource "cloudfoundry_app" "egress_app" {
        id                              = "5e81ca8b-99cf-41f8-ae42-76652d51a44c"
        name                            = "https-proxy"
      ~ source_code_hash                = "9fcf4a7f6abfc9a220de2b8bb97591ab490a271ac0933b984f606f645319e1a4" -> "cfddd8df06cdb61c6b5a5fe8b879a9ad5b8eeb0752a9f7d73bf4ae050184e237"
        # (19 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.domain.cloudfoundry_service_instance.external_domain_instance,
  on /tmp/terraform-data-dir/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
  45:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 3 more similar warnings elsewhere)

📝 Plan generated in Pull Request Checks #1371

[github-actions]

Terraform plan for staging

Plan: 0 to add, 1 to change, 0 to destroy.

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.staging.module.https-proxy.cloudfoundry_app.egress_app will be updated in-place
  ~ resource "cloudfoundry_app" "egress_app" {
        id                              = "1c9e7877-3c69-4fe5-8541-7bca3f845eb1"
        name                            = "https-proxy"
      ~ source_code_hash                = "9fcf4a7f6abfc9a220de2b8bb97591ab490a271ac0933b984f606f645319e1a4" -> "cfddd8df06cdb61c6b5a5fe8b879a9ad5b8eeb0752a9f7d73bf4ae050184e237"
        # (19 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.staging.module.database.cloudfoundry_service_instance.rds,
  on /tmp/terraform-data-dir/modules/staging.database/database/main.tf line 14, in resource "cloudfoundry_service_instance" "rds":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 2 more similar warnings elsewhere)

📝 Plan generated in Pull Request Checks #1371

[github-actions]

File	Coverage		Missing
All files	86%	❌
api/serializers.py	88%	❌	177-178 183 188
api/test_views.py	96%	✅	105
api/uei.py	87%	❌	17-18 87 119-120 164 168-169
api/views.py	97%	✅	196-197 204-205 226 362-363
audit/forms.py	47%	❌	22-29 142-149
audit/intake_to_dissemination.py	92%	✅	67-68 201-207 257
audit/models.py	86%	❌	57 59 64 66 213 246 419 437-438 446 468 544-545 549 557 566 572
audit/test_commands.py	87%	❌
audit/test_mixins.py	90%	✅	112-113 117-119 184-185 189-191
audit/test_validators.py	95%	✅	436 440 608-609 848 855 862 869
audit/test_workbooks_should_fail.py	85%	❌	56 83-84 88
audit/test_workbooks_should_pass.py	90%	✅	56 81
audit/utils.py	70%	❌	13 21 33-35 38
audit/validators.py	94%	✅	137 189 288-289 304-305 486-490 495-499 515-524
audit/views.py	42%	❌	87-108 131-132 206-207 252-253 264-265 267-271 318-331 334-348 353-366 383-389 394-414 441-445 450-479 522-526 531-551 578-582 587-616 659-663 668-680 683-693 698-710 737-738 743-792 795-835 838-855
audit/cross_validation/additional_ueis.py	93%	✅	33
audit/cross_validation/check_award_ref_declaration.py	90%	✅
audit/cross_validation/check_award_reference_uniqueness.py	93%	✅
audit/cross_validation/check_certifying_contacts.py	87%	❌
audit/cross_validation/check_findings_count_consistency.py	91%	✅
audit/cross_validation/check_ref_number_in_cap.py	90%	✅
audit/cross_validation/check_ref_number_in_findings_text.py	90%	✅
audit/cross_validation/errors.py	78%	❌	30 69
audit/cross_validation/naming.py	68%	❌	178-182
audit/cross_validation/submission_progress_check.py	92%	✅	62 79
audit/cross_validation/tribal_data_sharing_consent.py	81%	❌	33 36 40
audit/cross_validation/validate_general_information.py	93%	✅	28-29
audit/fixtures/single_audit_checklist.py	79%	❌	156 231-240
audit/intakelib/exceptions.py	71%	❌	7-9 12
audit/intakelib/intermediate_representation.py	94%	✅	23-24 87 125 158 182-185
audit/intakelib/mapping_audit_findings.py	97%	✅	51
audit/intakelib/mapping_audit_findings_text.py	97%	✅	51
audit/intakelib/mapping_federal_awards.py	93%	✅	87
audit/intakelib/mapping_util.py	40%	❌	28 32 36 70-99 104 124-135 142-158 162-167 171-185 190 195-215 220-237 258 263-264 273-279 289 304 309
audit/intakelib/checks/check_all_unique_award_numbers.py	79%	❌	24
audit/intakelib/checks/check_cluster_name_always_present.py	82%	❌	21
audit/intakelib/checks/check_federal_award_passed_always_present.py	82%	❌	18
audit/intakelib/checks/check_findings_grid_validation.py	84%	❌	57
audit/intakelib/checks/check_is_a_workbook.py	68%	❌	16
audit/intakelib/checks/check_loan_guarantee.py	81%	❌	42 51
audit/intakelib/checks/check_look_for_empty_rows.py	91%	✅	18
audit/intakelib/checks/check_missing_award_numbers.py	72%	❌	16 22-23
audit/intakelib/checks/check_no_major_program_no_type.py	72%	❌	22 31 40
audit/intakelib/checks/check_no_repeat_findings.py	76%	❌	17 26
audit/intakelib/checks/check_other_cluster_names.py	81%	❌	24 34
audit/intakelib/checks/check_passthrough_name_when_no_direct.py	88%	❌	9 47
audit/intakelib/checks/check_sequential_award_numbers.py	76%	❌	14 22
audit/intakelib/checks/check_start_and_end_rows_of_all_columns_are_same.py	89%	❌	14
audit/intakelib/checks/check_state_cluster_names.py	65%	❌	23-24 34
audit/intakelib/checks/check_uei_exists.py	65%	❌	17-18
audit/intakelib/checks/runners.py	90%	✅	98 104
audit/intakelib/checks/util.py	84%	❌	16 33 38
audit/management/commands/load_fixtures.py	46%	❌	39-45
audit/viewlib/submission_progress_view.py	96%	✅	171-172
audit/viewlib/tribal_data_consent.py	34%	❌	23-41 44-79
audit/viewlib/upload_report_view.py	26%	❌	32-35 44 91-117 120-170 178-209
cms/views.py	57%	❌	11-16 29-30
config/urls.py	71%	❌	87
dissemination/models.py	99%	✅	460
dissemination/migrations/0002_general_fac_accepted_date.py	47%	❌	10-12
djangooidc/backends.py	78%	❌	32 57-63
djangooidc/exceptions.py	66%	❌	19 21 23 28
djangooidc/oidc.py	16%	❌	32-35 45-51 64-70 92-149 153-199 203-226 230-275 280-281 286
djangooidc/views.py	80%	❌	22 43 114
djangooidc/tests/common.py	96%	✅
report_submission/forms.py	92%	✅	35
report_submission/views.py	76%	❌	83 215-216 218 240-241 260-261 287-396 399-409
report_submission/templatetags/get_attr.py	76%	❌	8 11-14 18
support/admin.py	88%	❌	76 79 84 91-97 100-102
support/cog_over.py	90%	✅	30-33 86 93 145
support/signals.py	66%	❌	23-24 33-34
support/test_cog_over.py	98%	✅	134-135 224
support/management/commands/seed_cog_baseline.py	98%	✅	20-21
tools/update_program_data.py	89%	❌	96
users/auth.py	95%	✅	40-41
users/models.py	97%	✅	51-52
users/fixtures/user_fixtures.py	91%	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 65e0c54

[tadhg-ohiggins]

The a11y tests are failing for reasons unrelated to these changes. Merging.