Summary Updates

[jperson1]

Summary Updates

Base branch PR: #2419

Changes:

1. Summary HTML -
   • New design. Table-based and pulls from the generals table, with download links (only the PDF one points anywhere).
   • Data that doesn't exist (additional UEIs/EINs, zero findings submissions) will show in "disabled" boxes. As in they exist, but just show lighter text with no link.
2. Add django.contrib.humanize to the installed apps. This gives access to some useful templatetags, like intcomma.
3. Main scss:
   • Add a weight for semibold (600). This isn't set to anything by default.
   • Override theme-color-base-lighter to be... even lighter. Used for a single background.
4. getkey.py - a template tag to allow accessing dictionary members with spaces, as though one used data.'Notes to Sefa'. Which doesn't exist in Django, hence the template tag.
5. Minor cleanup. A return here, a comment type there.

How to Test:

1. Switch to this branch and run normally.
2. Ensure there is data in your dissemination tables. If not, submit an audit or have Cypress submit an audit (or three or six).
3. Search for an audit. Visit its summary page.
4. Verify that information is showing correctly. In particular, eyeball:
   • The PDF download link
   • The funky-fresh separated table
   • The download links that were a pain to line up properly.
5. Mess around with the screen size to see if things break significantly. I doubt we will have many mobile users, but it's nice to be inclusive.

Screenshot:

PR checklist: submitters

• Link to an issue if possible. If there’s no issue, describe what your branch does. Even if there is an issue, a brief description in the PR is still useful.
• List any special steps reviewers have to follow to test the PR. For example, adding a local environment variable, creating a local test file, etc.
• For extra credit, submit a screen recording like this one.
• Make sure you’ve merged main into your branch shortly before creating the PR. (You should also be merging main into your branch regularly during development.)
• Make sure you’ve accounted for any migrations. When you’re about to create the PR, bring up the application locally and then run git status | grep migrations. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-run python manage.py makemigrations to reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)
• Make sure that whatever feature you’re adding has tests that cover the feature. This includes test coverage to make sure that the previous workflow still works, if applicable.
• Make sure the full-submission.cy.js Cypress test passes, if applicable.
• Do manual testing locally. Our tests are not good enough yet to allow us to skip this step. If that’s not applicable for some reason, check this box.
• Verify that no Git surgery was necessary, or, if it was necessary at any point, repeat the testing after it’s finished.
• Once a PR is merged, keep an eye on it until it’s deployed to dev, and do enough testing on dev to verify that it deployed successfully, the feature works as expected, and the happy path for the broad feature area (such as submission) still works.

PR checklist: reviewers

• Pull the branch to your local environment and run make docker-clean; make docker-first-run && docker compose up; then run docker compose exec web /bin/bash -c "python manage.py test"
• Manually test out the changes locally, or check this box to verify that it wasn’t applicable in this case.
• Check that the PR has appropriate tests. Look out for changes in HTML/JS/JSON Schema logic that may need to be captured in Python tests even though the logic isn’t in Python.
• Verify that no Git surgery is necessary at any point (such as during a merge party), or, if it was, repeat the testing after it’s finished.

The larger the PR, the stricter we should be about these points.