-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update requirements moving model_bakery to primary requirements out of dev #2638
Closed
tadhg-ohiggins
wants to merge
1
commit into
main
from
tadhg/bake-model-bakery-in-since-we-use-baker-insert-cake-joke-here
Closed
Update requirements moving model_bakery to primary requirements out of dev #2638
tadhg-ohiggins
wants to merge
1
commit into
main
from
tadhg/bake-model-bakery-in-since-we-use-baker-insert-cake-joke-here
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform plan for dev No changes. Your infrastructure matches the configuration.
📝 Plan generated in Pull Request Checks #1509 |
Terraform plan for meta No changes. Your infrastructure matches the configuration.
📝 Plan generated in Pull Request Checks #1509 |
Minimum allowed coverage is Generated by 🐒 cobertura-action against b45fbf9 |
Apparently we weren't using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
“The bakery’s open.”
“Bake it until you make it.”
“Bread: not just for devs.”
Since we’re now using workbook generation in more places, and specifically via backend/dissemination/management/commands/end_to_end_test_data_generator.py, we need to move
model_bakery
out ofdev-requirements
and intorequirements
If the tests pass, this PR should be fine.