Change auditee/auditor certifying official #2891

tadhg-ohiggins · 2023-11-29T05:16:28Z

Certifying—who?
But it should be someone else!
Let users change it.

The certifying official parts of #2812.

Includes:

The URLs/routes for changing the certifying auditee/auditor contact .
The view classs for changing the certifying auditee/auditor contact.
GET support plus the form and page and interim design/layout for changing the certifying auditee/auditor contact.
POST support for changing the certifying auditee/auditor contact.
Redirection back to submission progress upon success.
Atomic transaction support so that the deletion of the old Access only occurs if the new one is valid.
Logic to prevent changing the certifying auditor contact to the same email address as the certifying auditee contact, and vice versa, plus an error message for this.
Tests.

Does not include:

A link to this page from anywhere else.
Final copy for the page.
Final layout/design for the page.
Error messages/error handling for any errors other than the one around trying to set the same email address as the certifying auditee contact.
The more general “manage submission” page from which this page will be linked.
Support for adding editors.

Local testing should probably include changing each of these (available from /audit/manage-submission/auditee-certifying-official/<str:report_id> and /audit/manage-submission/auditor-certifying-official/<str:report_id>) and verifying that the changes show up in the database. Also that you can't submit the same email address for both roles.

Screenshot of form

Screenshot of form with error

PR checklist: submitters

PR checklist: reviewers

Pull the branch to your local environment and run make docker-clean; make docker-first-run && docker compose up; then run docker compose exec web /bin/bash -c "python manage.py test"
Manually test out the changes locally, or check this box to verify that it wasn’t applicable in this case.
Check that the PR has appropriate tests. Look out for changes in HTML/JS/JSON Schema logic that may need to be captured in Python tests even though the logic isn’t in Python.
Verify that no Git surgery is necessary at any point (such as during a merge party), or, if it was, repeat the testing after it’s finished.

The larger the PR, the stricter we should be about these points.

github-actions · 2023-11-29T05:17:12Z

Terraform plan for meta

No changes. Your infrastructure matches the configuration.

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.s3-backups.cloudfoundry_service_instance.bucket,
  on /tmp/terraform-data-dir/modules/s3-backups/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

✅ Plan applied in Deploy to Development and Management Environment #386

github-actions · 2023-11-29T05:17:20Z

Terraform plan for dev

No changes. Your infrastructure matches the configuration.

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.dev.module.database-c2g.cloudfoundry_service_instance.rds,
  on /tmp/terraform-data-dir/modules/dev.database-c2g/database/main.tf line 14, in resource "cloudfoundry_service_instance" "rds":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 4 more similar warnings elsewhere)

✅ Plan applied in Deploy to Development and Management Environment #386

github-actions · 2023-11-29T05:32:28Z

File	Coverage		Missing
All files	`86%`	✅
api/serializers.py	`88%`	✅	`177-178` `183` `188`
api/test_views.py	`95%`	✅	`103`
api/uei.py	`88%`	✅	`87` `118-119` `163` `167-168`
api/views.py	`98%`	✅	`195-196` `334-335`
audit/file_downloads.py	`73%`	❌	`35-53` `81-83`
audit/forms.py	`47%`	❌	`22-29` `142-149`
audit/intake_to_dissemination.py	`92%`	✅	`67-68` `201-207` `257`
audit/test_commands.py	`87%`	✅
audit/test_manage_submission_access_view.py	`97%`	✅	`15` `19`
audit/test_mixins.py	`90%`	✅	`112-113` `117-119` `184-185` `189-191`
audit/test_validators.py	`95%`	✅	`436` `440` `608-609` `848` `855` `862` `869`
audit/test_views.py	`95%`	✅	`410-442` `451-482` `491-519`
audit/test_workbooks_should_fail.py	`88%`	✅	`56` `83-84` `88`
audit/test_workbooks_should_pass.py	`90%`	✅	`56` `71`
audit/utils.py	`70%`	❌	`13` `21` `33-35` `38`
audit/validators.py	`92%`	✅	`137` `189` `283-292` `299-308` `486-490` `495-499` `515-524`
audit/cross_validation/additional_ueis.py	`93%`	✅	`33`
audit/cross_validation/check_award_ref_declaration.py	`90%`	✅
audit/cross_validation/check_award_reference_uniqueness.py	`93%`	✅
audit/cross_validation/check_certifying_contacts.py	`87%`	✅
audit/cross_validation/check_findings_count_consistency.py	`91%`	✅
audit/cross_validation/check_ref_number_in_cap.py	`90%`	✅
audit/cross_validation/check_ref_number_in_findings_text.py	`90%`	✅
audit/cross_validation/errors.py	`78%`	❌	`30` `69`
audit/cross_validation/naming.py	`93%`	✅	`182`
audit/cross_validation/submission_progress_check.py	`95%`	✅	`79`
audit/cross_validation/tribal_data_sharing_consent.py	`81%`	❌	`33` `36` `40`
audit/cross_validation/validate_general_information.py	`93%`	✅	`28-29`
audit/fixtures/single_audit_checklist.py	`55%`	❌	`146-183` `229-238`
audit/intakelib/exceptions.py	`71%`	❌	`7-9` `12`
audit/intakelib/intermediate_representation.py	`91%`	✅	`27-28` `73` `91` `129` `162` `200-203` `212-213`
audit/intakelib/mapping_audit_findings.py	`97%`	✅	`53`
audit/intakelib/mapping_audit_findings_text.py	`97%`	✅	`52`
audit/intakelib/mapping_federal_awards.py	`93%`	✅	`95`
audit/intakelib/mapping_util.py	`81%`	❌	`21` `25` `29` `99` `104-105` `114-120` `130` `145` `150`
audit/intakelib/checks/check_all_unique_award_numbers.py	`79%`	❌	`24`
audit/intakelib/checks/check_cluster_total.py	`85%`	✅	`49` `65`
audit/intakelib/checks/check_finding_prior_references_pattern.py	`73%`	❌	`33` `43-44`
audit/intakelib/checks/check_findings_grid_validation.py	`84%`	❌	`58`
audit/intakelib/checks/check_has_all_the_named_ranges.py	`84%`	❌	`52`
audit/intakelib/checks/check_is_a_workbook.py	`69%`	❌	`20`
audit/intakelib/checks/check_loan_balance_entries.py	`78%`	❌	`22` `39-40`
audit/intakelib/checks/check_loan_balance_present.py	`76%`	❌	`27` `36`
audit/intakelib/checks/check_look_for_empty_rows.py	`91%`	✅	`18`
audit/intakelib/checks/check_no_major_program_no_type.py	`76%`	❌	`18` `27`
audit/intakelib/checks/check_no_repeat_findings.py	`76%`	❌	`21` `30`
audit/intakelib/checks/check_other_cluster_names.py	`81%`	❌	`24` `34`
audit/intakelib/checks/check_passthrough_name_when_no_direct.py	`88%`	✅	`9` `47`
audit/intakelib/checks/check_sequential_award_numbers.py	`76%`	❌	`14` `22`
audit/intakelib/checks/check_show_ir.py	`70%`	❌	`8-14`
audit/intakelib/checks/check_start_and_end_rows_of_all_columns_are_same.py	`89%`	✅	`14`
audit/intakelib/checks/check_state_cluster_names.py	`65%`	❌	`23-24` `34`
audit/intakelib/checks/check_version_number.py	`73%`	❌	`21` `31-32`
audit/intakelib/checks/runners.py	`95%`	✅	`129`
audit/intakelib/common/util.py	`89%`	✅	`21` `38`
audit/intakelib/transforms/xform_reformat_prior_references.py	`55%`	❌	`12-17`
audit/intakelib/transforms/xform_rename_additional_notes_sheet.py	`81%`	❌	`14`
audit/management/commands/load_fixtures.py	`46%`	❌	`39-45`
audit/models/models.py	`82%`	❌	`57` `59` `64` `66` `216` `228-231` `249` `422` `440-441` `449` `471` `560-561` `565` `573` `582` `588`
audit/views/manage_submission_access.py	`92%`	✅	`76-82`
audit/views/submission_progress_view.py	`96%`	✅	`171-172`
audit/views/tribal_data_consent.py	`34%`	❌	`23-41` `44-79`
audit/views/unlock_after_certification.py	`57%`	❌	`28-47` `69-83`
audit/views/upload_report_view.py	`26%`	❌	`32-35` `44` `91-117` `120-170` `178-209`
audit/views/views.py	`31%`	❌	`80-101` `124-125` `199-200` `245-246` `257-258` `260-264` `311-324` `327-341` `346-359` `376-382` `387-407` `410-438` `443-472` `475-519` `524-544` `547-575` `580-609` `612-656` `661-673` `676-686` `691-703` `730-731` `736-785` `788-828` `831-848`
census_historical_migration/base_field_maps.py	`93%`	✅	`29-30`
census_historical_migration/exception_utils.py	`75%`	❌	`5-6`
census_historical_migration/sac_general_lib/report_id_generator.py	`68%`	❌	`11-18` `27-28`
census_historical_migration/sac_general_lib/utils.py	`23%`	❌	`11-32` `36-56` `62-64`
census_historical_migration/transforms/xform_string_to_bool.py	`11%`	❌	`4-14`
census_historical_migration/transforms/xform_string_to_date.py	`22%`	❌	`6-15`
census_historical_migration/transforms/xform_string_to_int.py	`55%`	❌	`4` `6` `13-14`
census_historical_migration/transforms/xform_string_to_string.py	`60%`	❌	`6` `8`
census_historical_migration/workbooklib/excel_creation_utils.py	`47%`	❌	`130-135` `140-142` `147-151` `155-170` `180-187` `194-198` `202-232` `236`
config/test_settings.py	`90%`	✅	`21-22` `39-40` `55-56`
config/urls.py	`71%`	❌	`83`
dissemination/models.py	`99%`	✅	`461`
dissemination/search.py	`59%`	❌	`55-83` `90-100`
dissemination/views.py	`82%`	❌	`106` `108-110` `135` `187` `189` `191`
dissemination/migrations/0002_general_fac_accepted_date.py	`47%`	❌	`10-12`
djangooidc/backends.py	`78%`	❌	`32` `57-63`
djangooidc/exceptions.py	`66%`	❌	`19` `21` `23` `28`
djangooidc/oidc.py	`16%`	❌	`32-35` `45-51` `64-70` `92-149` `153-199` `203-226` `230-275` `280-281` `286`
djangooidc/views.py	`80%`	❌	`22` `43` `114`
djangooidc/tests/common.py	`96%`	✅
report_submission/forms.py	`92%`	✅	`35`
report_submission/views.py	`76%`	❌	`83` `215-216` `218` `240-241` `260-261` `287-396` `399-409`
report_submission/templatetags/get_attr.py	`76%`	❌	`8` `11-14` `18`
support/admin.py	`88%`	✅	`76` `79` `84` `91-97` `100-102`
support/cog_over.py	`91%`	✅	`30-33` `93` `145`
support/models.py	`89%`	✅	`103-104`
support/test_cog_over.py	`98%`	✅	`134-135` `224`
support/management/commands/seed_cog_baseline.py	`98%`	✅	`20-21`
tools/update_program_data.py	`89%`	✅	`96`
users/admin.py	`98%`	✅	`25`
users/auth.py	`96%`	✅	`58-59`
users/models.py	`96%`	✅	`18` `74-75`
users/fixtures/user_fixtures.py	`91%`	✅

Minimum allowed coverage is 85%

Generated by 🐒 cobertura-action against 126416f

timoballard

looks good!

timoballard · 2023-11-29T15:19:34Z

backend/audit/views/manage_submission_access.py

+    # email_confirm = forms.EmailField()
+
+    # def clean(self):
+    #     cleaned = super().clean()
+    #     if cleaned.get("email") != cleaned.get("email_confirm"):
+    #         raise ValidationError(
+    #             "Email address and confirmed email address must match"
+    #         )


is this a placeholder or should it be removed?

I'm not sure we need the confirmation email here (or whether it would be client-side only) but I decided I'd leave this as a placeholder for now.

* Add GET side of page for changing Auditor Certifying Official. * Add POST side of page for changing Auditor Certifying Official. * Remove stray import. * Add page for changing Auditee Certifying Official. * Use variable for role in template instead of hard-coding. * Typo correction.

* Table scrolling, hide modal button, big reformats * Move resultcount out of horizontal scroll, padding * Search results ALNs - my/all ALN columns * A big bundle of linting * Undo djlint autoformat. * Tests for ALN search. Basic & finding_my/all_aln * Break ALN tests into their own class, and into more pieces. * Linting! Yippee! * Bools in ALN test cases - explicit for readability * Comment consistency * End date autofill fix * Search instructions link. * Use a separate PG DB for Census data (#2573) * Add bucket and DB * Lint * Formatting * Duplicate changes to compose-web * Fix naming errors * Try separate database * WIp * Get config test to pass * Make same changes in docker-compose-web --------- Co-authored-by: Alex Steel <[email protected]> * Add functions and tests for deleting `Access` entries and creating corresponding `DeletedAccess` entries (#2849) * Add functions and tests for deleting Access entries and creating corresponding DeletedAccess entries. * Add migration file. * Actually use ACCESS_ROLES in Access. * Type hinting corrections. * Actually check in access_roles.py. * Make tests more readable. * Make tests more readable. * Account for role when using remove_email_from_submission_access. * Add test as per PR comment. * Break up audit views (#2862) * First pass at moving views. * Move imports around to fit new setup. * 2861 update logic to use elecaudits model (#2863) * #2861 Update model mappings tfor federal awards worbook creation * #Refactor code to make it more re-usable * #2861 Code improvement * #2861 More util functions and tests * #2861 Generate workbooks to ensure the updated code is still working as expected * Linting * #2861 Regenerated workbooks to only include dbkeys that are available in census table * #2861 Regenerated workbooks to only include dbkeys that are available in census tables * #2861 Improved logic in light of data discoveries * Added to commit by mistake * #2861 Moved shared logic to a common area * Update backend/census_historical_migration/test_excel_creation.py Co-authored-by: Dan Swick <[email protected]> * Linting * Fix for failing test --------- Co-authored-by: Dan Swick <[email protected]> * Command to run census migration by year (#2868) * Slicing last 2 year digits for dynamic_import * Adding new command * Renaming command to run_migration_for_year * Renaming load_data to load_historic_data_for_year * Renaming loader to historic_data_loader * Lint * Docstrings * Teaking user creation * Utilizing results dict * Lint * Fixing historic_data_migrator --------- Co-authored-by: Phil Dominguez <“[email protected]”> * Sk/hist migration failure models (#2845) * Added FAILED_SACS and CHANGE_RECORDS models * Routing CHANGE_RECORDS to fac db * Initial commit * Migration for FAILED_SACS, CHANGE_RECORDS tables * Registering ELECAUDITHEADER, FAILED_SACS, CHANGE_RECORDS models * Test cases for ELECAUDITHEADER, FAILED_SACS, CHANGE_RECORDS models * Formatted with black * Modified FailedSacs and ChangeRecords table per JMM's request * Modified FailedSacs and ChangeRecords table per JMM's request * Modified FailedSacs and ChangeRecords table per JMM's request * Modified FailedSacs and ChangeRecords table per JMM's request * Modified FailedSacs and ChangeRecords table per JMM's request * Modified FailedSacs and ChangeRecords table per JMM's request * Updating migrations * Updating migrations * Updating migrations * Updated migrations * Modifications based on meeting * Modifications based on meeting * Modifications based on meeting * Modifications based on meeting * Modifications based on meeting * Modifications based on meeting * Modifications based on meeting * Modifications based on meeting * Modifications based on ADR * Modifications based on ADR * Modifications based on ADR * Modifications based on ADR * Implemented changes per ADR review * Implemented changes per ADR review * Implemented changes per ADR review * Implemented changes per ADR review * Implemented changes per ADR review * Implemented changes per ADR review * Implemented changes per ADR review * Implemented changes per ADR review * Implemented changes per ADR review * Implemented changes per ADR review * Implemented changes per ADR review * Fixed lint issue * Redid migrations * Replaced sac with record_id * Replaced sac with record_id * Registering all models * Update backend/dissemination/models.py Co-authored-by: Hassan D. M. Sambo <[email protected]> * Redid migrations * Renamed record_id as report_id * Renamed record_id as report_id * Added databases to route to census-to-gsafac db --------- Co-authored-by: Hassan D. M. Sambo <[email protected]> * 2880 update logic in secondary auditors generator to use census models (#2881) * #2861 Update model mappings tfor federal awards worbook creation * #Refactor code to make it more re-usable * #2861 Code improvement * #2861 More util functions and tests * #2861 Generate workbooks to ensure the updated code is still working as expected * Linting * #2861 Regenerated workbooks to only include dbkeys that are available in census table * #2861 Regenerated workbooks to only include dbkeys that are available in census tables * #2861 Improved logic in light of data discoveries * Added to commit by mistake * #2861 Moved shared logic to a common area * #2880 Updated logic to use census models * #2880 Regenerated workbooks to ensure logic works as intended * Updated migrator command to use or create default user * Updated wrong mapping * More update to improve the api test * search: filter by auditee state (#2888) * 2864 update logic in findings generator to use census models (#2866) * #2861 Update model mappings tfor federal awards worbook creation * #Refactor code to make it more re-usable * #2861 Code improvement * #2861 More util functions and tests * #2861 Generate workbooks to ensure the updated code is still working as expected * Linting * #2861 Regenerated workbooks to only include dbkeys that are available in census table * #2861 Regenerated workbooks to only include dbkeys that are available in census tables * #2861 Improved logic in light of data discoveries * Added to commit by mistake * #2864 Moved shared logic to common area * #2864 Moved shared logic to common area * #2864 Updated logic to use census models and tables * #2864 Regenerated workbooks since this is crutial to ensure the code is still behaving as intended * #2861 Moved shared logic to a common area * Sk/2874 retain null values, 2886 test cases for census models (#2887) * Replace NaN with empty string * Added test cases for census models * Change auditee/auditor certifying official (#2891) * Add GET side of page for changing Auditor Certifying Official. * Add POST side of page for changing Auditor Certifying Official. * Remove stray import. * Add page for changing Auditee Certifying Official. * Use variable for role in template instead of hard-coding. * Typo correction. * 2870 update logic in corrective action plan generator to use census models (#2872) * #2861 Update model mappings tfor federal awards worbook creation * #Refactor code to make it more re-usable * #2861 Code improvement * #2861 More util functions and tests * #2861 Generate workbooks to ensure the updated code is still working as expected * Linting * #2861 Regenerated workbooks to only include dbkeys that are available in census table * #2861 Regenerated workbooks to only include dbkeys that are available in census tables * #2861 Improved logic in light of data discoveries * Added to commit by mistake * #2861 Moved shared logic to a common area * #2870 Updated logic to use census models * #2870 Updated workbooks to ensure the code still behaves as intended * Bug fixed in api_check routine * Fixed bogus row count * 2867 update logic in findings text generator to use census models (#2869) * #2861 Update model mappings tfor federal awards worbook creation * #Refactor code to make it more re-usable * #2861 Code improvement * #2861 More util functions and tests * #2861 Generate workbooks to ensure the updated code is still working as expected * Linting * #2861 Regenerated workbooks to only include dbkeys that are available in census table * #2861 Regenerated workbooks to only include dbkeys that are available in census tables * #2861 Improved logic in light of data discoveries * Added to commit by mistake * #2864 Moved shared logic to common area * #2864 Moved shared logic to common area * #2864 Updated logic to use census models and tables * #2864 Regenerated workbooks since this is crutial to ensure the code is still behaving as intended * #2861 Moved shared logic to a common area * #2867 Updated logic to use census models and tables * #2867 Regenerated workbooks to ensure the code is still behaving as intended * 2873 update logic in additional ein generator to use census models (#2875) * #2861 Update model mappings tfor federal awards worbook creation * #Refactor code to make it more re-usable * #2861 Code improvement * #2861 More util functions and tests * #2861 Generate workbooks to ensure the updated code is still working as expected * Linting * #2861 Regenerated workbooks to only include dbkeys that are available in census table * #2861 Regenerated workbooks to only include dbkeys that are available in census tables * #2861 Improved logic in light of data discoveries * Added to commit by mistake * #2864 Moved shared logic to common area * #2864 Moved shared logic to common area * #2864 Updated logic to use census models and tables * #2864 Regenerated workbooks since this is crutial to ensure the code is still behaving as intended * #2861 Moved shared logic to a common area * #2867 Updated logic to use census models and tables * #2867 Regenerated workbooks to ensure the code is still behaving as intended * #2873 Updated logic to use Census models * #2873 Generated workbooks to ensure the logic works as intended * Updated test workbooks * More bug fix in the test table generation logic * 2883 update logic in notes to sefa workbook generator to use census models (#2899) * #2883 Updated logic to use Census models * #2883 Updated workbooks * Update backend/census_historical_migration/workbooklib/notes_to_sefa.py Co-authored-by: Phil Dominguez <[email protected]> * Update backend/census_historical_migration/test_core_xforms.py Co-authored-by: Phil Dominguez <[email protected]> --------- Co-authored-by: Phil Dominguez <[email protected]> * Django admin improvements. (#2907) * 2895: New cmd for paginated census migration (#2905) * Creating paginated command * Updating readme * Lint * Using django paginator * Using page_size instead of batchSize * Readme tweak * Readme tweak * Update backend/census_historical_migration/README.md --------- Co-authored-by: Phil Dominguez <“[email protected]”> Co-authored-by: Hassan D. M. Sambo <[email protected]> * 2901 update logic in general information to use census models (#2906) * #2901 Updated logic to use Census models * Code improvement * Update backend/census_historical_migration/sac_general_lib/general_information.py Co-authored-by: Phil Dominguez <[email protected]> * Update backend/census_historical_migration/sac_general_lib/audit_information.py * Linting --------- Co-authored-by: Phil Dominguez <[email protected]> * Initial manage submission page (#2904) * WIP check-in for manage submission page. * Tests, some minor refactoring. * Django lint tweak. * Remove unnecessary util function. * Search results ALNs - my/all ALN columns * A big bundle of linting * Undo djlint autoformat. * Tests for ALN search. Basic & finding_my/all_aln * Add instructions for production ssh to deploying.md. (#2937) * Break ALN tests into their own class, and into more pieces. * Linting! Yippee! * Bools in ALN test cases - explicit for readability * Stray code block line deletion (#2939) * Add instructions for production ssh to deploying.md. * Remove stray code block start line. * Comment consistency * End date autofill fix * Search instructions link. --------- Co-authored-by: JeanMarie Mariadassou <[email protected]> Co-authored-by: Alex Steel <[email protected]> Co-authored-by: Tadhg O'Higgins <[email protected]> Co-authored-by: Hassan D. M. Sambo <[email protected]> Co-authored-by: Dan Swick <[email protected]> Co-authored-by: Phil Dominguez <[email protected]> Co-authored-by: Phil Dominguez <“[email protected]”> Co-authored-by: Sudha Kumar <[email protected]> Co-authored-by: Tim Ballard <[email protected]>

tadhg-ohiggins added 4 commits November 28, 2023 11:10

Add GET side of page for changing Auditor Certifying Official.

a218aaa

Add POST side of page for changing Auditor Certifying Official.

d0b434e

Remove stray import.

0d4329b

Add page for changing Auditee Certifying Official.

5f0a7da

tadhg-ohiggins requested review from timoballard and jperson1 November 29, 2023 05:16

tadhg-ohiggins temporarily deployed to dev November 29, 2023 05:16 — with GitHub Actions Inactive

tadhg-ohiggins temporarily deployed to meta November 29, 2023 05:16 — with GitHub Actions Inactive

Use variable for role in template instead of hard-coding.

7d4fbd8

tadhg-ohiggins temporarily deployed to dev November 29, 2023 05:26 — with GitHub Actions Inactive

tadhg-ohiggins temporarily deployed to meta November 29, 2023 05:26 — with GitHub Actions Inactive

Typo correction.

126416f

tadhg-ohiggins temporarily deployed to dev November 29, 2023 07:11 — with GitHub Actions Inactive

tadhg-ohiggins temporarily deployed to meta November 29, 2023 07:11 — with GitHub Actions Inactive

timoballard approved these changes Nov 29, 2023

View reviewed changes

tadhg-ohiggins added this pull request to the merge queue Nov 29, 2023

Merged via the queue into main with commit 653cf28 Nov 29, 2023
13 checks passed

tadhg-ohiggins deleted the tadhg/access-change-auditor-certifying branch November 29, 2023 17:01

tadhg-ohiggins mentioned this pull request Dec 13, 2023

Epic: user role management #2812

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change auditee/auditor certifying official #2891

Change auditee/auditor certifying official #2891

tadhg-ohiggins commented Nov 29, 2023 •

edited by timoballard

Loading

github-actions bot commented Nov 29, 2023 •

edited

Loading

github-actions bot commented Nov 29, 2023 •

edited

Loading

github-actions bot commented Nov 29, 2023 •

edited

Loading

timoballard left a comment

timoballard Nov 29, 2023

tadhg-ohiggins Nov 29, 2023

Change auditee/auditor certifying official #2891

Change auditee/auditor certifying official #2891

Conversation

tadhg-ohiggins commented Nov 29, 2023 • edited by timoballard Loading

Screenshot of form

Screenshot of form with error

PR checklist: submitters

PR checklist: reviewers

github-actions bot commented Nov 29, 2023 • edited Loading

github-actions bot commented Nov 29, 2023 • edited Loading

github-actions bot commented Nov 29, 2023 • edited Loading

timoballard left a comment

Choose a reason for hiding this comment

timoballard Nov 29, 2023

Choose a reason for hiding this comment

tadhg-ohiggins Nov 29, 2023

Choose a reason for hiding this comment

tadhg-ohiggins commented Nov 29, 2023 •

edited by timoballard

Loading

github-actions bot commented Nov 29, 2023 •

edited

Loading

github-actions bot commented Nov 29, 2023 •

edited

Loading

github-actions bot commented Nov 29, 2023 •

edited

Loading