2023-12-04 main -> prod #2917
Merged
2023-12-04 main -> prod #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP check-in for manage submission page. * Tests, some minor refactoring. * Django lint tweak. * Remove unnecessary util function.
tadhg-ohiggins
temporarily deployed
to
production
GitHub Actions
Inactive
tadhg-ohiggins
temporarily deployed
to
staging
GitHub Actions
Inactive
|
Terraform plan for staging Plan: 0 to add, 1 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# module.staging.cloudfoundry_app.postgrest will be updated in-place
~ resource "cloudfoundry_app" "postgrest" {
~ docker_image = "ghcr.io/gsa-tts/fac/postgrest@sha256:b1b1d0be42868fe621f1162fbe8734f0121a27fc11ef3e8344dc1e8757a1e436" -> "ghcr.io/gsa-tts/fac/postgrest@sha256:278d977ccf40ab16c5b9aa1570ecb4df68ec853431b3a5ee749e2733263df837"
id = "db50e549-24c7-4dcf-b30e-e9dee3512be8"
name = "postgrest"
# (15 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
Warning: Argument is deprecated
with module.staging.module.database-c2g.cloudfoundry_service_instance.rds,
on /tmp/terraform-data-dir/modules/staging.database-c2g/database/main.tf line 14, in resource "cloudfoundry_service_instance" "rds":
14: recursive_delete = var.recursive_delete
Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases
(and 4 more similar warnings elsewhere)✅ Plan applied in Deploy to Staging Environment #99 |
|
Terraform plan for production Plan: 2 to add, 1 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
~ update in-place
Terraform will perform the following actions:
# module.production.cloudfoundry_app.postgrest will be updated in-place
~ resource "cloudfoundry_app" "postgrest" {
~ docker_image = "ghcr.io/gsa-tts/fac/postgrest@sha256:b1b1d0be42868fe621f1162fbe8734f0121a27fc11ef3e8344dc1e8757a1e436" -> "ghcr.io/gsa-tts/fac/postgrest@sha256:278d977ccf40ab16c5b9aa1570ecb4df68ec853431b3a5ee749e2733263df837"
id = "70ac44be-3507-4867-a75f-c2d1ab12ee89"
name = "postgrest"
# (15 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.production.module.database-c2g.cloudfoundry_service_instance.rds will be created
+ resource "cloudfoundry_service_instance" "rds" {
+ id = (known after apply)
+ name = "fac-c2g-db"
+ replace_on_params_change = false
+ replace_on_service_plan_change = false
+ service_plan = "c1ddc2d6-983b-4ced-9995-064d9dde07aa"
+ space = "5593dba8-7023-49a5-bdbe-e809fe23edf9"
}
# module.production.module.s3-c2g.cloudfoundry_service_instance.bucket will be created
+ resource "cloudfoundry_service_instance" "bucket" {
+ id = (known after apply)
+ name = "fac-c2g-s3"
+ replace_on_params_change = false
+ replace_on_service_plan_change = false
+ service_plan = "021bb2a3-7e11-4fc2-b06b-d9f5938cd806"
+ space = "5593dba8-7023-49a5-bdbe-e809fe23edf9"
}
Plan: 2 to add, 1 to change, 0 to destroy.
Warning: Argument is deprecated
with module.domain.cloudfoundry_service_instance.external_domain_instance,
on /tmp/terraform-data-dir/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
45: recursive_delete = var.recursive_delete
Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases
(and 5 more similar warnings elsewhere)📝 Plan generated in Pull Request Checks #1810 |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against de38b0e |
timoballard
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP check-in for manage submission page.
Tests, some minor refactoring.
Django lint tweak.
Remove unnecessary util function.
PR checklist: submitters
maininto your branch shortly before creating the PR. (You should also be mergingmaininto your branch regularly during development.)git status | grep migrations. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-runpython manage.py makemigrationsto reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)PR checklist: reviewers
make docker-clean; make docker-first-run && docker compose up; then rundocker compose exec web /bin/bash -c "python manage.py test"The larger the PR, the stricter we should be about these points.