Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023-12-23 | MAIN --> PROD | DEV (a660153) --> STAGING #3080

Merged
merged 2 commits into from
Dec 23, 2023
Merged

2023-12-23 | MAIN --> PROD | DEV (a660153) --> STAGING #3080

merged 2 commits into from
Dec 23, 2023

Conversation

jadudm
Copy link
Contributor

@jadudm jadudm commented Dec 23, 2023

This is an auto-generated pull request to merge main into prod for a staging release on 2023-12-23 with the last commit being merged as a660153

@jadudm jadudm added autogenerated Automated pull request creation automerge Used for automated deployments labels Dec 23, 2023
Copy link
Contributor

github-actions bot commented Dec 23, 2023

Terraform plan for staging

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.staging.module.cg-logshipper.module.s3-logshipper-storage.cloudfoundry_service_instance.bucket,
  on /tmp/terraform-data-dir/modules/staging.cg-logshipper.s3-logshipper-storage/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 5 more similar warnings elsewhere)

✅ Plan applied in Deploy to Staging Environment #116

Copy link
Contributor

Terraform plan for production

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.domain.cloudfoundry_service_instance.external_domain_instance,
  on /tmp/terraform-data-dir/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
  45:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 6 more similar warnings elsewhere)

📝 Plan generated in Pull Request Checks #2001

Copy link
Contributor

File Coverage Missing
All files 87%
api/serializers.py 88% 177-178 183 188
api/test_views.py 95% 103
api/uei.py 88% 87 118-119 163 167-168
api/views.py 98% 198-199 337-338
audit/forms.py 47% 22-29 142-149
audit/intake_to_dissemination.py 88% 71-72 205-211 261 300-306
audit/test_commands.py 87%
audit/test_manage_submission_access_view.py 98% 15 19
audit/test_mixins.py 90% 112-113 117-119 184-185 189-191
audit/test_validators.py 95% 436 440 608-609 848 855 862 869
audit/test_views.py 95% 410-442 451-482 491-519
audit/test_workbooks_should_fail.py 88% 56 83-84 88
audit/utils.py 70% 13 21 33-35 38
audit/validators.py 92% 137 189 283-292 299-308 486-490 495-499 515-524
audit/cross_validation/additional_ueis.py 93% 33
audit/cross_validation/check_award_ref_declaration.py 90%
audit/cross_validation/check_award_reference_uniqueness.py 93%
audit/cross_validation/check_certifying_contacts.py 87%
audit/cross_validation/check_findings_count_consistency.py 91%
audit/cross_validation/check_ref_number_in_cap.py 90%
audit/cross_validation/check_ref_number_in_findings_text.py 90%
audit/cross_validation/errors.py 78% 30 69
audit/cross_validation/naming.py 93% 197
audit/cross_validation/submission_progress_check.py 95% 80
audit/cross_validation/tribal_data_sharing_consent.py 81% 33 36 40
audit/cross_validation/validate_general_information.py 93% 28-29
audit/fixtures/single_audit_checklist.py 55% 146-183 229-238
audit/intakelib/exceptions.py 71% 7-9 12
audit/intakelib/intermediate_representation.py 91% 27-28 73 91 129 200-203 212-213
audit/intakelib/mapping_audit_findings.py 97% 55
audit/intakelib/mapping_audit_findings_text.py 97% 52
audit/intakelib/mapping_federal_awards.py 93% 90
audit/intakelib/mapping_util.py 81% 21 25 29 99 104-105 114-120 130 145 150
audit/intakelib/checks/check_all_unique_award_numbers.py 79% 24
audit/intakelib/checks/check_cluster_names.py 80% 21-26
audit/intakelib/checks/check_cluster_total.py 85% 57 73
audit/intakelib/checks/check_finding_prior_references_pattern.py 73% 33 43-44
audit/intakelib/checks/check_findings_grid_validation.py 84% 58
audit/intakelib/checks/check_has_all_the_named_ranges.py 84% 52
audit/intakelib/checks/check_is_a_workbook.py 69% 20
audit/intakelib/checks/check_loan_balance_entries.py 79% 26 43-44
audit/intakelib/checks/check_loan_balance_present.py 76% 27 36
audit/intakelib/checks/check_look_for_empty_rows.py 91% 18
audit/intakelib/checks/check_no_major_program_no_type.py 76% 18 27
audit/intakelib/checks/check_no_repeat_findings.py 76% 21 30
audit/intakelib/checks/check_other_cluster_names.py 81% 23 33
audit/intakelib/checks/check_passthrough_name_when_no_direct.py 88% 9 47
audit/intakelib/checks/check_sequential_award_numbers.py 76% 14 22
audit/intakelib/checks/check_show_ir.py 70% 8-14
audit/intakelib/checks/check_start_and_end_rows_of_all_columns_are_same.py 89% 14
audit/intakelib/checks/check_state_cluster_names.py 65% 22-23 33
audit/intakelib/checks/check_version_number.py 73% 21 31-32
audit/intakelib/checks/runners.py 92% 140 146
audit/intakelib/common/util.py 90% 22 39
audit/intakelib/transforms/xform_reformat_prior_references.py 55% 12-17
audit/intakelib/transforms/xform_rename_additional_notes_sheet.py 81% 14
audit/management/commands/load_fixtures.py 46% 39-45
audit/models/models.py 83% 57 59 64 66 216 228-231 249 426 444-445 453 475 564-565 569 577 586 592
audit/views/audit_info_form_view.py 27% 25-74 77-117 120-137
audit/views/manage_submission.py 86% 73-80
audit/views/manage_submission_access.py 98% 113-114
audit/views/pre_dissemination_download_view.py 76% 15-18 23-26 33-43
audit/views/submission_progress_view.py 89% 111 171-172
audit/views/tribal_data_consent.py 34% 23-41 44-79
audit/views/unlock_after_certification.py 57% 28-47 69-83
audit/views/upload_report_view.py 26% 32-35 44 91-117 120-170 178-209
audit/views/views.py 39% 69 76-95 118-119 193-194 239-240 251-252 254-258 305-318 321-335 340-353 370-376 381-401 404-432 437-466 469-513 518-538 541-569 574-603 606-650 655-667 670-680 685-697 724-725
census_historical_migration/test_federal_awards_xforms.py 99% 194-195
census_historical_migration/sac_general_lib/audit_information.py 70% 19-23 72-78 157-169
census_historical_migration/sac_general_lib/general_information.py 83% 172 241-262
census_historical_migration/sac_general_lib/report_id_generator.py 68% 11-16
census_historical_migration/sac_general_lib/utils.py 87% 32-35
census_historical_migration/transforms/xform_retrieve_uei.py 42% 7-12
census_historical_migration/workbooklib/additional_eins.py 83% 58 65-79
census_historical_migration/workbooklib/excel_creation_utils.py 53% 102 145-150 155-162 166-184 197-201 209-234 239
census_historical_migration/workbooklib/federal_awards.py 58% 166 176-200 307-461
census_historical_migration/workbooklib/notes_to_sefa.py 53% 33-37 87-93 101-107 115 124-168
config/test_settings.py 90% 21-22 39-40 55-56
config/urls.py 71% 83
dissemination/file_downloads.py 73% 35-53 83-85
dissemination/models.py 99% 461
dissemination/search.py 84% 58 88 94 123 125 128-136
dissemination/summary_reports.py 68% 268-270 274-278 355-399 424 460-462 477-484
dissemination/views.py 84% 166 170 200 248 250 252 293-297
dissemination/migrations/0002_general_fac_accepted_date.py 47% 10-12
djangooidc/backends.py 78% 32 57-63
djangooidc/exceptions.py 66% 19 21 23 28
djangooidc/oidc.py 16% 32-35 45-51 64-70 92-149 153-199 203-226 230-275 280-281 286
djangooidc/views.py 80% 22 43 114
djangooidc/tests/common.py 96%
report_submission/forms.py 92% 35
report_submission/views.py 76% 83 215-216 218 240-241 260-261 287-396 399-409
report_submission/templatetags/get_attr.py 76% 8 11-14 18
support/admin.py 88% 76 79 84 91-97 100-102
support/cog_over.py 91% 30-33 93 145
support/test_admin_api.py 80% 22 146-147 236-237 316-317
support/test_cog_over.py 98% 134-135 224
support/management/commands/seed_cog_baseline.py 98% 20-21
support/models/cog_over.py 89% 103-104
tools/update_program_data.py 89% 96
users/admin.py 99% 27
users/auth.py 96% 58-59
users/models.py 96% 18 74-75
users/fixtures/user_fixtures.py 91%

Minimum allowed coverage is 85%

Generated by 🐒 cobertura-action against a660153

@jadudm jadudm merged commit a26fdc3 into prod Dec 23, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autogenerated Automated pull request creation automerge Used for automated deployments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants