Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-07-27 | MAIN --> PROD | DEV (fc6eeda) --> STAGING #4119

Merged
merged 1 commit into from
Jul 27, 2024
Merged

2024-07-27 | MAIN --> PROD | DEV (fc6eeda) --> STAGING #4119

merged 1 commit into from
Jul 27, 2024

Conversation

jadudm
Copy link
Contributor

@jadudm jadudm commented Jul 27, 2024

This is an auto-generated pull request to merge main into prod for a staging release on 2024-07-27 with the last commit being merged as fc6eeda

* Initial cors script test

* add depends_on

* Trying out the cors json via jsonencode

* add var

* testing

* give interpreter and working_dir

* add cf target command

* add aws

* trim space

* give proper path for aws

* force delete key

* set the actual domain

* trying decoded json

* more testing

* trying map

* Testing decoded_json local

* Testing moving the string json into module

* typo fix

* Undo the decode

* Make executable

* Test with json file

* change script_path

* add trigger

* Fix the jq

* Add env specific CORS files

* Add info statements for logs

* Add a small sleep for CF API

* Quiet unzip output

* rename resource

* Add an informational comment on why the trigger={} was added
@jadudm jadudm added autogenerated Automated pull request creation automerge Used for automated deployments labels Jul 27, 2024
Copy link
Contributor

Terraform plan for production

Plan: 1 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create

Terraform will perform the following actions:

  # module.production.module.cors.null_resource.cors_header will be created
+   resource "null_resource" "cors_header" {
+       id       = (known after apply)
+       triggers = {
+           "always_run" = (known after apply)
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.domain.cloudfoundry_service_instance.external_domain_instance,
  on /tmp/terraform-data-dir/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
  45:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 6 more similar warnings elsewhere)

📝 Plan generated in Pull Request Checks #3376

Copy link
Contributor

github-actions bot commented Jul 27, 2024

Terraform plan for staging

Plan: 1 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create

Terraform will perform the following actions:

  # module.staging.module.cors.null_resource.cors_header will be created
+   resource "null_resource" "cors_header" {
+       id       = (known after apply)
+       triggers = {
+           "always_run" = (known after apply)
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.staging-backups-bucket.cloudfoundry_service_instance.bucket,
  on /tmp/terraform-data-dir/modules/staging-backups-bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 6 more similar warnings elsewhere)

✅ Plan applied in Deploy to Staging Environment #243

Copy link
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
18026 16473 91% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: fc6eeda by action🐍

@jadudm jadudm merged commit fa6f900 into prod Jul 27, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autogenerated Automated pull request creation automerge Used for automated deployments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants