2024-08-15 | MAIN --> PROD | DEV (212a90e) --> STAGING #4189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Django * Update pip-tools
* Enabling a11y workflows * Bumping node used to 18 * Commenting out django-test to test faster * Trying to get cypress running * Adding back start service step * Fixing .env location * Trying node 20 * Removing upload-artifact for now * Adding npm ci * Trying i instead of ci * Removing sudo * Fixing a11y finding * Adding load_fixtures * Swapping up and load_fixtures * Fixing a11y cancel button findings * Running login test before load_fixtures * Setting DISABLED_AUTH * Adding login creds * Setting staging env * Enabling screenshot upload * Commenting out login and load_fixtures * CYPRESS_DISABLE_AUTH=false and commenting out 3 failing tests * Actually setting CYPRESS_DISABLE_AUTH=false * Trying docker-compose-web * Removing staging * Setting DISABLE_AUTH to false * Using node-version 18 * Going back to 18 * Moving cypress env vars * Trying docker-first-run * Uncommented some a11y tests * Removing login test stuff * Setting DISABLE_AUTH to true * Creating MV * Using docker to create MV * Uncommenting out django tests
* #3748 Added logic to remove workbook artifacts once report is successfully disseminated * Linting * More linting * Update backend/dissemination/remove_workbook_artifacts.py Co-authored-by: Phil Dominguez <[email protected]> * Fixed typo in function name --------- Co-authored-by: Phil Dominguez <[email protected]>
jadudm
added
autogenerated
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Terraform plan for staging Plan: 1 to add, 0 to change, 1 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.staging.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~ id = "*******************" -> (known after apply)
!~ triggers = { # forces replacement
!~ "always_run" = "2024-08-14T11:13:01Z" -> (known after apply)
}
}
Plan: 1 to add, 0 to change, 1 to destroy.
Warning: Argument is deprecated
with module.staging-backups-bucket.cloudfoundry_service_instance.bucket,
on /tmp/terraform-data-dir/modules/staging-backups-bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
14: recursive_delete = var.recursive_delete
Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases
(and 6 more similar warnings elsewhere)✅ Plan applied in Deploy to Staging Environment #254 |
|
Terraform plan for production Plan: 1 to add, 0 to change, 1 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.production.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~ id = "*******************" -> (known after apply)
!~ triggers = { # forces replacement
!~ "always_run" = "2024-08-14T17:32:02Z" -> (known after apply)
}
}
Plan: 1 to add, 0 to change, 1 to destroy.
Warning: Argument is deprecated
with module.domain.cloudfoundry_service_instance.external_domain_instance,
on /tmp/terraform-data-dir/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
45: recursive_delete = var.recursive_delete
Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases
(and 6 more similar warnings elsewhere)📝 Plan generated in Pull Request Checks #3471 |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an auto-generated pull request to merge main into prod for a staging release on 2024-08-15 with the last commit being merged as 212a90e