Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-09-07 | MAIN --> PROD | DEV (5dc66d2) --> STAGING #4262

Merged
merged 3 commits into from
Sep 7, 2024
Merged

2024-09-07 | MAIN --> PROD | DEV (5dc66d2) --> STAGING #4262

merged 3 commits into from
Sep 7, 2024

Conversation

jadudm
Copy link
Contributor

@jadudm jadudm commented Sep 7, 2024

This is an auto-generated pull request to merge main into prod for a staging release on 2024-09-07 with the last commit being merged as 5dc66d2

jperson1 and others added 3 commits September 6, 2024 14:37
#4193)

* #3748 Added logic to delete unnecessary workbook artifacts via django command

* #3748 Updated django command to remove files from  S3 only

* Bug fix

* Fixed linting

* Fixed unit tests
@jadudm jadudm added autogenerated Automated pull request creation automerge Used for automated deployments labels Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Terraform plan for staging

Plan: 1 to add, 0 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.staging.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2024-09-06T11:09:22Z" -> (known after apply)
        }
    }

Plan: 1 to add, 0 to change, 1 to destroy.

Warning: Argument is deprecated

  with module.staging-backups-bucket.cloudfoundry_service_instance.bucket,
  on /tmp/terraform-data-dir/modules/staging-backups-bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 6 more similar warnings elsewhere)

✅ Plan applied in Deploy to Staging Environment #265

Copy link
Contributor

github-actions bot commented Sep 7, 2024

Terraform plan for production

Plan: 1 to add, 0 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.production.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "*******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2024-09-04T17:55:50Z" -> (known after apply)
        }
    }

Plan: 1 to add, 0 to change, 1 to destroy.

Warning: Argument is deprecated

  with module.domain.cloudfoundry_service_instance.external_domain_instance,
  on /tmp/terraform-data-dir/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
  45:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 6 more similar warnings elsewhere)

📝 Plan generated in Pull Request Checks #3619

Copy link
Contributor

github-actions bot commented Sep 7, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
18378 16735 91% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 5dc66d2 by action🐍

@jadudm jadudm merged commit 10069e4 into prod Sep 7, 2024
78 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autogenerated Automated pull request creation automerge Used for automated deployments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants