-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to test_views.py from old branch #4546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4213-improve-views-coverage
Terraform plan for meta No changes. Your infrastructure matches the configuration.
✅ Plan applied in Deploy to Development and Management Environment #887 |
Terraform plan for dev Plan: 1 to add, 0 to change, 1 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~ id = "*******************" -> (known after apply)
!~ triggers = { # forces replacement
!~ "always_run" = "2024-12-12T19:08:39Z" -> (known after apply)
}
}
Plan: 1 to add, 0 to change, 1 to destroy. ✅ Plan applied in Deploy to Development and Management Environment #887 |
phildominguez-gsa
requested changes
Dec 13, 2024
|
phildominguez-gsa
approved these changes
Dec 13, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist: Submitter
Link to Issue
Link to main issue.
Note
Reformatted file with black, isort, and ran a flake8 test. This is a clone PR of #4500 to deal with commit signing.
Added Tests:
EditSubmissionViewTests.setUp
EditSubmissionViewTests.test_redirect_not_logged_in
SubmissionViewTests.setUp
SubmissionViewTests.test_get_renders_template
SubmissionViewTests.def test_get_permission_denied_if_no_sac
SubmissionViewTests.def test_get_access_denied_for_unauthorized_user
SubmissionViewTests.test_post_valid_submission
SubmissionViewTests.test_post_validation_errors
SubmissionViewTests.test_post_transaction_error
SubmissionViewTests.test_post_permission_denied_if_no_sac
SubmissionGetTest.testValidSubmission
SubmissionStatusTests.test_get_login_required
SubmissionStatusTests.test_get_bad_report_id_returns_403
EditSubmissionTest.setUp
EditSubmissionTest.test_redirects_to_singleauditchecklist
AuditorCertificationStep1ViewTests.setUp
AuditorCertificationStep1ViewTests.test_get_redirects_if_status_not_ready_for_certification
AuditorCertificationStep1ViewTests.test_get_renders_template_if_valid_state
AuditorCertificationStep1ViewTests.test_get_permission_denied_if_sac_not_found
AuditorCertificationStep1ViewTests.test_post_redirects_if_status_not_ready_for_certification
AuditorCertificationStep1ViewTests.test_post_valid_form
AuditorCertificationStep1ViewTests.test_post_invalid_form
AuditorCertificationStep1ViewTests.test_post_permission_denied_if_sac_not_found
AuditeeCertificationStep2ViewTests.setUp
AuditeeCertificationStep2ViewTests.test_get_redirects_if_no_step_1
AuditeeCertificationStep2ViewTests.test_get_renders_template_if_valid_session
AuditeeCertificationStep2ViewTests.test_get_redirects_if_not_auditor_certified
AuditeeCertificationStep2ViewTests.test_redirects_if_no_step_1_session
AuditeeCertificationStep2ViewTests.test_post_valid_form
AuditeeCertificationStep2ViewTests.test_post_invalid_form
AuditeeCertificationStep2ViewTests.test_post_redirects_if_status_not_auditor_certified
AuditeeCertificationStep2ViewTests.test_single_audit_checklist_does_not_exist_exception
CrossValidationViewTests.setUp
CrossValidationViewTests.test_get_view_renders_correct_template
CrossValidationViewTests.test_get_view_permission_denied
CrossValidationViewTests.test_post_view_renders_results_template
CrossValidationViewTests.test_post_view_permission_denied
Test Command
To test the file only, use manage.py test audit.test_views
Last Merge
Main was merged to branch on 12/02/24
PR Checklist: Reviewer
make docker-clean; make docker-first-run && docker compose up
; then rundocker compose exec web /bin/bash -c "python manage.py test"
The larger the PR, the stricter we should be about these points.
Pre Merge Checklist: Merger
-/+ resource "null_resource" "cors_header"
should be destroying and recreating its self and~ resource "cloudfoundry_app" "clamav_api"
might be updating itssha256
for thefac-file-scanner
andfac-av-${ENV}
by default.main
.