Update caddy to 2.8 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogul
approved these changes
Sep 26, 2024
| sed -i 's/# tls cert.pem key.pem/tls cert.pem key.pem/g' proxy/Caddyfile | ||
| rm allow.acl deny.acl | ||
| sed -i.bak 's/# tls cert.pem key.pem/tls cert.pem key.pem/g' proxy/Caddyfile | ||
| rm proxy/Caddyfile.bak allow.acl deny.acl |
There was a problem hiding this comment.
Same here... Why create a .bak file if we have no intention of leaving it around?
There was a problem hiding this comment.
because sed -i 's... doesn't work on macos (-i requires an argument) and the internet says that while sed -i '' will work on macos it will break on linux. The only fully cross-platform way is to create the backup file and then remove it
There was a problem hiding this comment.
Ahhhh, so that's the M1-specific update you made... I was wondering.
Do you want to leave a comment to that effect, with a reference? That will stop ignorant folks like me from removing it in future updates.
There was a problem hiding this comment.
would it make more sense to just install gnu-sed with homebrew?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
validateis still broken due to incompatible architecture issuesMarking this as draft until I'm able to deploy this to a known-working 2.7 proxy setup to verify no downstream surprises