Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ALB Controller to provision NLBs #69

Merged
merged 13 commits into from
Feb 8, 2022
Merged

Conversation

nickumia-reisys
Copy link
Contributor

@nickumia-reisys nickumia-reisys commented Feb 4, 2022

Related to GSA/data.gov#3677

New Additions:

  • Add VPC CNI for EKS cluster
  • Convert Application Load Balancer to Network Load Balancer

Upgrades:

  • Update AWS LB Controller to 2.3

reconfigure Ingress to give the ALB 'LoadBalancer' servive type for NLB configuration
…nx service

* NLB is provisioned
* Target groups appear healthy
* DNS entry is created
* Traffic is getting all the way through to the ingress-nginx controller ("400 bad request" from nginx)
nickumia-reisys and others added 5 commits February 7, 2022 11:21
Parsing the LB name out of 'data.kubernetes_service.ingress_service' is hard, so let's see if this passes
Also removes some extraneous parameters (the defaults are fine), and configures the controller to pass through the real client IP.
It's 'degraded' until it has enough replicas in EKS which varies on the number of nodes in the EKS cluster, it then becomes 'active'
@nickumia-reisys
Copy link
Contributor Author

Before we merge this, I want to verify that we have no issues uploading a solr configset. We might need the 307 Redirect implemented somewhere. Will update soon! 😀

@nickumia-reisys
Copy link
Contributor Author

Success!! 🥳
image

Copy link
Collaborator

@mogul mogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the vpc cni information/option make sense here? It's kind of required for everything were brokering to work. (I was thinking the docs belong on the ALB installation module.)

@nickumia-reisys
Copy link
Contributor Author

Does the vpc cni information/option make sense here? It's kind of required for everything were brokering to work. (I was thinking the docs belong on the ALB installation module.)

That makes a lot more sense as to why you wanted to document it. I think this becomes a very niche use case of using both the datagov-brokerpak-eks AND the terraform-kubernetes-aws-load-balancer-controller. I definitely agree, the documentation I added here was more for terraform-kubernetes-aws-load-balancer-controller. I still think it makes sense here because the NLB is technically an optional requirement to EKS workloads in general. If we want to support a more dynamic Load Balancing design in the future, the documentation here becomes more relevant. I will also add it to the other repo too.

auto-merge was automatically disabled February 8, 2022 17:39

Pull request was closed

@nickumia-reisys nickumia-reisys enabled auto-merge (squash) February 8, 2022 17:39
@nickumia-reisys nickumia-reisys merged commit dededd8 into main Feb 8, 2022
@nickumia-reisys nickumia-reisys deleted the alb-upgrade branch February 8, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants