Skip to content

Commit

Permalink
debugging issue on main (#235)
Browse files Browse the repository at this point in the history
* debugging issue on main with end-to-end tests
  • Loading branch information
ethangardner authored Jul 1, 2024
1 parent 701d4eb commit 292e88b
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 6 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/_playwright.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
name: Playwright Tests
on:
# push:
# branches: [ main, master ]
pull_request:
branches: [ main, master ]
workflow_call:

jobs:
end_to_end:
timeout-minutes: 60
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ jobs:
secrets: inherit
with:
deploy-env: ${{ github.ref_name }}

e2e:
needs: [deploy]
uses: ./.github/workflows/_playwright.yml
secrets: inherit
secrets: inherit
18 changes: 18 additions & 0 deletions documents/adr/0010-end-to-end-testing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# 10. End to end testing

Date: 2024-07-01

## Status

Pending

## Context

Certain tests are not able to be performed with Storybook and JSDOM (e.g. drag-and-drop). The ability to replicate more complex user interactions in the test suite through an actual browser can provide this feature.

## Decision
The end-to-end tests should be used sparingly since they are slower to run than the ones through JSDOM. Storybook still should be the primary mechanism for testing, and the Playwright tests will round out what isn't possible there.

## Consequences

The deployed application will include Playwright tests in the e2e package.

0 comments on commit 292e88b

Please sign in to comment.