Add tests for process-session-cookie

packages/auth/src/context/test.ts

@@ -1,4 +1,5 @@
 import { Cookie, Lucia } from 'lucia';
+import { vi } from 'vitest';
 
 import {
   type TestDatabaseContext,
@@ -9,7 +10,18 @@ import { type AuthContext, type UserSession } from '..';
 import { createTestLuciaAdapter } from '../lucia';
 import { LoginGov } from '../provider';
 
-export const createTestAuthContext = async () => {
+type Options = {
+  getCookie: (name: string) => string | undefined;
+  setCookie: (cookie: Cookie) => void;
+  setUserSession: (userSession: UserSession) => void;
+};
+
+export const createTestAuthContext = async (opts?: Partial<Options>) => {
+  const options: Options = {
+    getCookie: opts?.getCookie || vi.fn(),
+    setCookie: opts?.setCookie || vi.fn(),
+    setUserSession: opts?.setUserSession || vi.fn(),
+  };
   const database = await createTestDatabaseContext();
   return new TestAuthContext(
     database,
@@ -20,11 +32,9 @@ export const createTestAuthContext = async () => {
       clientSecret: 'super-secret',
       redirectURI: 'http://www.10x.gov/a2j/signin/callback',
     }),
-    function getCookie(name) {
-      return '';
-    },
-    function setCookie(cookie) {},
-    function setUserSession({ user, session }) {}
+    options.getCookie,
+    options.setCookie,
+    options.setUserSession
   );
 };
 

packages/auth/src/services/process-session-cookie.test.ts

@@ -1,17 +1,135 @@
+import { randomUUID } from 'crypto';
 import { beforeEach, describe, expect, it, vi } from 'vitest';
 
-import { createUser } from '@atj/database';
+import { createSession, createUser } from '@atj/database';
 
-import { processProviderCallback } from './process-provider-callback';
 import { createTestAuthContext } from '../context/test';
-import { AuthContext } from '..';
+import { processSessionCookie } from './process-session-cookie';
 
 describe('processSessionCookie', () => {
-  let ctx: AuthContext;
+  const today = new Date(2020, 1, 1);
+  const tenYearsAgo = new Date(2010, 1, 1);
 
-  it('works', async () => {
-    const ctx = await createTestAuthContext();
-    //processSessionCookie()
-    expect(true).toBe(true);
+  beforeEach(async () => {
+    vi.setSystemTime(today);
+  });
+
+  it('sets null user session with unset session cookie', async () => {
+    const mocks = {
+      getCookie: vi.fn(() => undefined),
+      setUserSession: vi.fn(),
+    };
+    const ctx = await createTestAuthContext(mocks);
+
+    const result = await processSessionCookie(
+      ctx,
+      new Request('http://localhost', {
+        headers: { Origin: 'http://localhost', Host: 'http://www.google.com' },
+      })
+    );
+
+    expect(result.success).toEqual(true);
+    expect(mocks.setUserSession).toHaveBeenCalledWith({
+      session: null,
+      user: null,
+    });
+  });
+
+  it('resets session cookie and sets user session with fresh session cookie', async () => {
+    const { ctx, mocks, sessionId, user } = await setUpTest(today);
+
+    const result = await processSessionCookie(
+      ctx,
+      new Request('http://localhost', {
+        headers: { Origin: 'http://localhost', Host: 'http://www.google.com' },
+      })
+    );
+
+    expect(result.success).toEqual(true);
+    expect(mocks.setCookie).toHaveBeenCalledWith(
+      expect.objectContaining({
+        attributes: {
+          httpOnly: true,
+          maxAge: 2592000,
+          path: '/',
+          sameSite: 'lax',
+          secure: false,
+        },
+        name: 'auth_session',
+        value: sessionId,
+      })
+    );
+    expect(mocks.setUserSession).toHaveBeenCalledWith(
+      expect.objectContaining({
+        session: {
+          expiresAt: expect.any(Date),
+          fresh: true,
+          id: sessionId,
+          userId: user.id,
+        },
+        user: {
+          email: '[email protected]',
+          id: user.id,
+        },
+      })
+    );
+  });
+
+  it('clears cookies with stale session cookie', async () => {
+    const { ctx, mocks } = await setUpTest(tenYearsAgo);
+
+    const result = await processSessionCookie(
+      ctx,
+      new Request('http://localhost', {
+        headers: { Origin: 'http://localhost', Host: 'http://www.google.com' },
+      })
+    );
+
+    expect(result.success).toEqual(true);
+    expect(mocks.setCookie).toHaveBeenCalledWith(
+      expect.objectContaining({
+        attributes: {
+          httpOnly: true,
+          maxAge: 0,
+          path: '/',
+          sameSite: 'lax',
+          secure: false,
+        },
+        name: 'auth_session',
+        value: '',
+      })
+    );
+    expect(mocks.setUserSession).toHaveBeenCalledWith(
+      expect.objectContaining({
+        session: null,
+        user: null,
+      })
+    );
   });
 });
+
+const addOneDay = (date: Date): Date => {
+  const newDate = new Date(date);
+  newDate.setDate(newDate.getDate() + 1);
+  return newDate;
+};
+
+const setUpTest = async (sessionExpirationDate: Date) => {
+  const mocks = {
+    getCookie: vi.fn(() => sessionId || ''),
+    setCookie: vi.fn(),
+    setUserSession: vi.fn(),
+  };
+  const ctx = await createTestAuthContext(mocks);
+  const user = await createUser(ctx.database, '[email protected]');
+  if (!user) {
+    expect.fail('error creating test user');
+  }
+  const sessionId = await createSession(ctx.database, {
+    id: randomUUID(),
+    expiresAt: addOneDay(sessionExpirationDate),
+    sessionToken: 'my-token',
+    userId: user.id,
+  });
+  return { ctx, mocks, sessionId, user };
+};

packages/auth/src/services/process-session-cookie.ts

@@ -24,7 +24,6 @@ export const processSessionCookie = async (
       };
     }
   }
-
   const lucia = await ctx.getLucia();
 
   const sessionId = ctx.getCookie(lucia.sessionCookieName);

packages/auth/vitest.config.ts

@@ -1,4 +1,4 @@
-import { defineConfig, defineProject, mergeConfig } from 'vitest/config';
+import { defineConfig, mergeConfig } from 'vitest/config';
 
 import sharedTestConfig from '../../vitest.shared';
 

vitest.shared.ts

@@ -8,7 +8,7 @@ export default {
       : ['default', 'html'],
     */
     coverage: {
-      enabled: true,
+      enabled: false,
       reporter: ['html', 'text', 'text-summary'],
       reportOnFailure: true,
     },