Skip to content

Commit

Permalink
To improve readability, use literal strings in login.gov unit test
Browse files Browse the repository at this point in the history
  • Loading branch information
danielnaab committed Jul 12, 2024
1 parent ee1b410 commit 8280a08
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions packages/secrets/src/commands/set-login-gov-secrets.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ describe('set-login-gov-secrets command', () => {
expect(
await context.vault.getSecrets(await context.vault.getSecretKeys())
).toEqual({
[`/tts-10x-atj-dev/${appKey}/login.gov/public-key`]: result.publicKey,
[`/tts-10x-atj-dev/${appKey}/login.gov/private-key`]: result.privateKey,
[`/tts-10x-atj-dev/${appKey}/login.gov/public-key`]: 'mock public key',
[`/tts-10x-atj-dev/${appKey}/login.gov/private-key`]: 'mock private key',
});
});

Expand All @@ -42,7 +42,7 @@ describe('set-login-gov-secrets command', () => {
};
const appKey = randomUUID();

const oldResult = await setLoginGovSecrets(
await setLoginGovSecrets(
{
...context,
generateLoginGovKey: async () => ({
Expand All @@ -69,9 +69,10 @@ describe('set-login-gov-secrets command', () => {
expect(
await context.vault.getSecrets(await context.vault.getSecretKeys())
).toEqual({
[`/tts-10x-atj-dev/${appKey}/login.gov/public-key`]: oldResult.publicKey,
[`/tts-10x-atj-dev/${appKey}/login.gov/public-key`]:
'mock public key - 1',
[`/tts-10x-atj-dev/${appKey}/login.gov/private-key`]:
oldResult.privateKey,
'mock private key - 1',
});
});
});

0 comments on commit 8280a08

Please sign in to comment.