refactor: Clear old error message on session object when updating val…

…id submission data and pass previous value into React component tckt-363 Co-authored-by: Daniel Naab [email protected]
GSA-TTS · Nov 13, 2024 · a89b9df · a89b9df
1 parent 31f98d3
commit a89b9df
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 8 deletions.
diff --git a/packages/forms/src/error.ts b/packages/forms/src/error.ts
@@ -1,8 +1,10 @@
 type FormErrorType = 'required' | 'custom';
 
-export type FormError = {
-  type: FormErrorType;
-  message?: string;
-};
+export type FormError =
+  | {
+      type?: FormErrorType;
+      message?: string;
+    }
+  | undefined;
 
 export type FormErrors = Record<string, FormError>;
diff --git a/packages/forms/src/pattern.ts b/packages/forms/src/pattern.ts
@@ -165,6 +165,7 @@ export const validatePatternAndChildren = (
 
     if (parseResult.success) {
       result.values[pattern.id] = parseResult.data;
+      result.errors[pattern.id] = undefined;
     } else {
       result.values[pattern.id] = values[pattern.id];
       result.errors[pattern.id] = parseResult.error;

diff --git a/packages/forms/src/patterns/page-set/submit.test.ts b/packages/forms/src/patterns/page-set/submit.test.ts
@@ -23,15 +23,17 @@ describe('Page-set submission', () => {
         session: {
           ...session,
           data: {
-            errors: {},
+            errors: {
+              'input-1': undefined,
+            },
             values: {
               'input-1': 'test',
             },
           },
           route: {
             url: '#',
             params: {
-              page: '1',
+              page: '0',
             },
           },
           form: session.form,

diff --git a/packages/forms/src/services/submit-form.test.ts b/packages/forms/src/services/submit-form.test.ts
@@ -261,14 +261,17 @@ describe('multi-page form', () => {
         session: {
           ...session,
           data: {
-            errors: {},
+            attachments: undefined,
+            errors: {
+              'element-1': undefined,
+            },
             values: {
               'element-1': 'test',
             },
           },
           route: {
             params: {
-              page: '1',
+              page: '0',
             },
             url: '#',
           },