Make clientSecret undefined rather than an empty string

GSA-TTS · Aug 9, 2024 · d6af3a7 · d6af3a7
1 parent 6b9008b
commit d6af3a7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/apps/server-doj/src/server.ts b/apps/server-doj/src/server.ts
@@ -21,7 +21,7 @@ export const createCustomServer = async (): Promise<any> => {
       loginGovUrl: 'https://idp.int.identitysandbox.gov',
       clientId:
         'urn:gov:gsa:openidconnect.profiles:sp:sso:gsa:tts-10x-atj-dev-server-doj',
-      clientSecret: '', // secrets.loginGovClientSecret,
+      //clientSecret: '', // secrets.loginGovClientSecret,
     },
   });
 };

diff --git a/apps/server-kansas/src/server.ts b/apps/server-kansas/src/server.ts
@@ -21,7 +21,7 @@ export const createCustomServer = async (): Promise<any> => {
       loginGovUrl: 'https://idp.int.identitysandbox.gov',
       clientId:
         'urn:gov:gsa:openidconnect.profiles:sp:sso:gsa:tts-10x-atj-dev-server-doj',
-      clientSecret: '', // secrets.loginGovClientSecret,
+      //clientSecret: '', // secrets.loginGovClientSecret,
     },
   });
 };

diff --git a/packages/auth/src/provider.ts b/packages/auth/src/provider.ts
@@ -15,13 +15,13 @@ const getAuthorizeEndpoint = (url: LoginGovUrl) =>
 export type LoginGovOptions = {
   loginGovUrl: LoginGovUrl;
   clientId: string;
-  clientSecret: string;
+  //clientSecret: string;
   redirectURI?: string;
 };
 
 export class LoginGov implements OAuth2ProviderWithPKCE {
   private client: OAuth2Client;
-  private clientSecret: string;
+  //private clientSecret: string;
 
   constructor(opts: LoginGovOptions) {
     this.client = new OAuth2Client(
@@ -32,7 +32,7 @@ export class LoginGov implements OAuth2ProviderWithPKCE {
         redirectURI: opts.redirectURI,
       }
     );
-    this.clientSecret = opts.clientSecret;
+    //this.clientSecret = opts.clientSecret;
   }
 
   public async createAuthorizationURL(