-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component library unit tests #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cribeStories - to compose storybook stories and their "play" functions into Vitest specs. Integrate so it's included with the workspace's coverage metrics. (there's a failing test that will be fixed in a follow-up commit.)
…n. This required added a "jsdom" environment annotation to every unit test file, despite there being a global jsdom environment configuration setting in the project. (running just the design test suite from the packages/design directory picks up the environment correctly; not so when the entire monorepo is tested at the same time).
…Html.js. Also, add linting to CI.
Coverage Report
File Coverage
|
…uild concurrency from the default of 10 to 5.
danielnaab
force-pushed
the
design-logic
branch
from
January 26, 2024 21:20
41349fe
to
c7887e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes unit tests for each UI component, wrapped with a helper called
describeStories
. This helper creates Vitest describe and test blocks for each story. The test renders stories via@testing-library/react
, and if it exists, invokes its interaction test (play
function).This PR wraps up the provisioning of Storybook and design components for #21, implementsing #36.