Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular imports in forms package #368

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

danielnaab
Copy link
Contributor

This removes circular imports from the forms package, which fixes a problem with Rollup's watch mode not working correctly with the main dev watch task.

This is currently branched off the branch in #358, but will be rebased over main once it is merged.

@danielnaab danielnaab changed the title Fix circular imports in forms package. This resolves a problem where … Fix circular imports in forms package Oct 30, 2024
@danielnaab danielnaab force-pushed the fix-circular-imports branch 2 times, most recently from f0c1074 to b427fba Compare November 1, 2024 17:48
Base automatically changed from submit-actions to main November 1, 2024 18:19
@danielnaab danielnaab force-pushed the fix-circular-imports branch from b427fba to efa9235 Compare November 1, 2024 18:21
Copy link

github-actions bot commented Nov 1, 2024

Terraform plan for tts-10x-atj-dev

Plan: 0 to add, 2 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place

Terraform will perform the following actions:

  # cloudfoundry_app.tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029 will be updated in-place
!~  resource "cloudfoundry_app" "tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029" {
!~      docker_image                    = "ghcr.io/gsa-tts/atj-platform/server-doj:266317897de2d31e9dd8524a066239bc3bb9be06" -> "ghcr.io/gsa-tts/atj-platform/server-doj:59849b4c387ff1cf0ea28ac25ced94305a70c47e"
        id                              = "6246c063-6cf4-423d-812a-4bfdeb62bcae"
        name                            = "tts-10x-atj-dev-server-doj-app"
#        (17 unchanged attributes hidden)

#        (3 unchanged blocks hidden)
    }

  # cloudfoundry_app.tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1 will be updated in-place
!~  resource "cloudfoundry_app" "tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1" {
!~      docker_image                    = "ghcr.io/gsa-tts/atj-platform/server-kansas:266317897de2d31e9dd8524a066239bc3bb9be06" -> "ghcr.io/gsa-tts/atj-platform/server-kansas:59849b4c387ff1cf0ea28ac25ced94305a70c47e"
        id                              = "f7c60971-bffd-4a6e-a0bb-af1191079918"
        name                            = "tts-10x-atj-dev-server-kansas-app"
#        (17 unchanged attributes hidden)

#        (3 unchanged blocks hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

📝 Plan generated in Post Terraform plan to PR comment #373

Copy link
Contributor

@ethangardner ethangardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielnaab danielnaab merged commit 10bd089 into main Nov 1, 2024
4 checks passed
@danielnaab danielnaab deleted the fix-circular-imports branch November 1, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants