feat: create date of birth pattern tckt-361 #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 5, 2024 13:03
|
Terraform plan for tts-10x-atj-dev Plan: 0 to add, 2 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# cloudfoundry_app.tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029 will be updated in-place
!~ resource "cloudfoundry_app" "tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029" {
!~ docker_image = "ghcr.io/gsa-tts/atj-platform/server-doj:8a7f9827a9a861a7ad510878dbd7faaffbf1b401" -> "ghcr.io/gsa-tts/atj-platform/server-doj:0ec86e0d7ec0ced5f6519c1eecf47964923e0de1"
id = "6246c063-6cf4-423d-812a-4bfdeb62bcae"
name = "tts-10x-atj-dev-server-doj-app"
# (17 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
# cloudfoundry_app.tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1 will be updated in-place
!~ resource "cloudfoundry_app" "tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1" {
!~ docker_image = "ghcr.io/gsa-tts/atj-platform/server-kansas:8a7f9827a9a861a7ad510878dbd7faaffbf1b401" -> "ghcr.io/gsa-tts/atj-platform/server-kansas:0ec86e0d7ec0ced5f6519c1eecf47964923e0de1"
id = "f7c60971-bffd-4a6e-a0bb-af1191079918"
name = "tts-10x-atj-dev-server-kansas-app"
# (17 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy.📝 Plan generated in Post Terraform plan to PR comment #386 |
danielnaab
requested changes
Nov 6, 2024
| const yearSchema = z | ||
| .string() | ||
| .regex(/^\d{4}$/, 'Invalid year format') | ||
| .optional(); |
There was a problem hiding this comment.
These schemas look correct, but I think we may want them to be coerced into numbers. @ethangardner thoughts?
There was a problem hiding this comment.
I am going to merge the current PR to unblock my next work, but in some point if want to update anything here I can raise a separate PR for it.
…le nested values tckt-361
kalasgarov
force-pushed
the
feature/361-date-input
branch
from
617cab7 to
c44d968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created Date of Birth Pattern for Forms Users.
Created Date of Birth Pattern Edit for Form Builders.
Added unit tests for Date of Birth Pattern.
Refactored and added value aggregation hook to handle structured and single values in form validation