-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve accessibility for single field components tckt-393 #387
Conversation
Terraform plan for tts-10x-atj-dev Plan: 0 to add, 2 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# cloudfoundry_app.tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029 will be updated in-place
!~ resource "cloudfoundry_app" "tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029" {
!~ docker_image = "ghcr.io/gsa-tts/forms/server-doj:47ea8ce4d918a6c2e82782097e07eb1aba09d078" -> "ghcr.io/gsa-tts/forms/server-doj:0aa87c95543c9d835bd1d9ab5cb731513490e3a8"
id = "8a9fc8b6-af5e-45a2-abb6-2c24ecbcdfaa"
name = "tts-10x-atj-dev-server-doj-app"
# (17 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
# cloudfoundry_app.tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1 will be updated in-place
!~ resource "cloudfoundry_app" "tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1" {
!~ docker_image = "ghcr.io/gsa-tts/forms/server-kansas:47ea8ce4d918a6c2e82782097e07eb1aba09d078" -> "ghcr.io/gsa-tts/forms/server-kansas:0aa87c95543c9d835bd1d9ab5cb731513490e3a8"
id = "e885e531-11b7-4906-9cc3-0ddf483868f5"
name = "tts-10x-atj-dev-server-kansas-app"
# (17 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy. 📝 Plan generated in Post Terraform plan to PR comment #450 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really appreciate you taking the time to do this! I left some comments for you on this one. The changes are minor tweaks to the aria labels, so I don't need to review again and can trust you to make the changes. I'll give it a conditional approval as long as the changes are implemented. Just merge it when the changes are complete.
packages/design/src/Form/components/DateOfBirth/DateOfBirth.tsx
Outdated
Show resolved
Hide resolved
packages/design/src/Form/components/DateOfBirth/DateOfBirth.tsx
Outdated
Show resolved
Hide resolved
packages/design/src/Form/components/DateOfBirth/DateOfBirth.tsx
Outdated
Show resolved
Hide resolved
packages/design/src/Form/components/PhoneNumber/PhoneNumber.tsx
Outdated
Show resolved
Hide resolved
packages/design/src/Form/components/SelectDropdown/SelectDropdown.tsx
Outdated
Show resolved
Hide resolved
246a6c5
to
81d49d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now. I really appreciate how you saw an opportunity and jumped in to fix it.
I think we probably have a need for some utility functions in the app for UI logic. I can see how the function you wrote for getting the aria-describedby
ids might be useful in both the form builder and form filler UI.
I think it should probably live in the common
package, but this isn't anything to address now. I'm more thinking out loud for the next epic. You're good to merge this to main.
Addressed some accessibility issues for single field components.
Improved error handling for single field components.