Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create gender identity input component tckt-365 #395

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

kalasgarov
Copy link
Contributor

Created Gender Id Pattern for Forms Users.
Created Gender Id Pattern Edit for Form Builders.
Created Gender Id input and config validations.
Added unit tests for Gender Id config file.

Copy link

github-actions bot commented Nov 29, 2024

Terraform plan for tts-10x-atj-dev

Plan: 0 to add, 2 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place

Terraform will perform the following actions:

  # cloudfoundry_app.tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029 will be updated in-place
!~  resource "cloudfoundry_app" "tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029" {
!~      docker_image                    = "ghcr.io/gsa-tts/forms/server-doj:d1c388f70764ab414f25157d6860b623a3d6ef7d" -> "ghcr.io/gsa-tts/forms/server-doj:befb0c6f4fd8e63cc1821e084df2192ede28bd4e"
        id                              = "8a9fc8b6-af5e-45a2-abb6-2c24ecbcdfaa"
        name                            = "tts-10x-atj-dev-server-doj-app"
#        (17 unchanged attributes hidden)

#        (3 unchanged blocks hidden)
    }

  # cloudfoundry_app.tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1 will be updated in-place
!~  resource "cloudfoundry_app" "tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1" {
!~      docker_image                    = "ghcr.io/gsa-tts/forms/server-kansas:d1c388f70764ab414f25157d6860b623a3d6ef7d" -> "ghcr.io/gsa-tts/forms/server-kansas:befb0c6f4fd8e63cc1821e084df2192ede28bd4e"
        id                              = "e885e531-11b7-4906-9cc3-0ddf483868f5"
        name                            = "tts-10x-atj-dev-server-kansas-app"
#        (17 unchanged attributes hidden)

#        (3 unchanged blocks hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

📝 Plan generated in Post Terraform plan to PR comment #465

@kalasgarov kalasgarov self-assigned this Nov 29, 2024
@kalasgarov kalasgarov force-pushed the feature/365-gender-id-input branch from 3f88d6f to 6cc6d47 Compare December 6, 2024 18:31
Copy link
Contributor

@ethangardner ethangardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. You're really working through these patterns quickly.

I did see two small suggestions that I left comments on. If you agree and want to make the changes, I think this is good to approve. If you want to discuss, let me know.

@kalasgarov kalasgarov force-pushed the feature/365-gender-id-input branch from 5456494 to 491d00c Compare December 6, 2024 19:38
@kalasgarov kalasgarov merged commit 193f9cd into main Dec 9, 2024
4 checks passed
@kalasgarov kalasgarov deleted the feature/365-gender-id-input branch December 9, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants