Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring actions #418

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Monitoring actions #418

wants to merge 23 commits into from

Conversation

ethangardner
Copy link
Contributor

Add guardrails as the application grows. This starts with a very conservative performance budget to make sure we don't grow our bundle sizes too far beyond where we're at currently.

@ethangardner ethangardner linked an issue Dec 18, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Dec 18, 2024

Terraform plan for tts-10x-atj-dev

Plan: 0 to add, 2 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place

Terraform will perform the following actions:

  # cloudfoundry_app.tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029 will be updated in-place
!~  resource "cloudfoundry_app" "tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029" {
!~      docker_image                    = "ghcr.io/gsa-tts/forms/server-doj:d692905ca9d9e0a5b19050682e83ae0beef67152" -> "ghcr.io/gsa-tts/forms/server-doj:b2d594f2aa44b115c810e051e656759edbef432b"
        id                              = "8a9fc8b6-af5e-45a2-abb6-2c24ecbcdfaa"
        name                            = "tts-10x-atj-dev-server-doj-app"
#        (17 unchanged attributes hidden)

#        (3 unchanged blocks hidden)
    }

  # cloudfoundry_app.tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1 will be updated in-place
!~  resource "cloudfoundry_app" "tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1" {
!~      docker_image                    = "ghcr.io/gsa-tts/forms/server-kansas:d692905ca9d9e0a5b19050682e83ae0beef67152" -> "ghcr.io/gsa-tts/forms/server-kansas:b2d594f2aa44b115c810e051e656759edbef432b"
        id                              = "e885e531-11b7-4906-9cc3-0ddf483868f5"
        name                            = "tts-10x-atj-dev-server-kansas-app"
#        (17 unchanged attributes hidden)

#        (3 unchanged blocks hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

📝 Plan generated in Post Terraform plan to PR comment #502

@ethangardner
Copy link
Contributor Author

The monitor budget action is failing in this PR and that is expected for now. The reason is that the GH action will run the test on the branch with the PR, and then switch to main and try run the test again to see if our bundles have gotten bigger or smaller.

The dependencies for the size-limit library aren't on main (they were added on this branch), so the test for monitoring the performance budget will fail until they are also on main. See: https://remarkablemark.org/blog/2020/12/20/size-limit-github-actions-workflow/

@ethangardner ethangardner marked this pull request as ready for review December 18, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add performance scan to CI/CD
1 participant