Add form field reordering / refactor strategies #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge, @atj/common. This avoid unresolved issues with exporting global types from packages.
…gy, with the intent of replacing it. This implements the form creation portion, and the edit UI still needs to be updated.
…oesn't interfere with the form field behavior.
…quire some additional effort.
Coverage Report
File CoverageNo changed files found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing #41, in order to reorder form fields, this PR adds the ability to drag-and-drag fields in the form manager interface.
To accommodate this, the notion of a "strategy" was removed in favor of more arbitrary resource types in the form definition. This may need to be revisited as we add additional behavior. Additionally, a new testing strategy is required, and will be added after a follow-up refactoring of how content types are defined.