Refactor pattern component wrappers #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…comonent itself, rather than in the form mechanics.
|
Terraform plan for tts-10x-atj-dev Plan: 0 to add, 2 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# cloudfoundry_app.tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029 will be updated in-place
!~ resource "cloudfoundry_app" "tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029" {
!~ docker_image = "ghcr.io/gsa-tts/forms/server-doj:b355f84dd5bd7cf8779360db7b238b6b5185856c" -> "ghcr.io/gsa-tts/forms/server-doj:7cbfe5b4707fef66acd948a41d4e8e5a38ea6a00"
id = "8a9fc8b6-af5e-45a2-abb6-2c24ecbcdfaa"
name = "tts-10x-atj-dev-server-doj-app"
# (17 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
# cloudfoundry_app.tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1 will be updated in-place
!~ resource "cloudfoundry_app" "tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1" {
!~ docker_image = "ghcr.io/gsa-tts/forms/server-kansas:b355f84dd5bd7cf8779360db7b238b6b5185856c" -> "ghcr.io/gsa-tts/forms/server-kansas:7cbfe5b4707fef66acd948a41d4e8e5a38ea6a00"
id = "e885e531-11b7-4906-9cc3-0ddf483868f5"
name = "tts-10x-atj-dev-server-kansas-app"
# (17 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy.📝 Plan generated in Post Terraform plan to PR comment #596 |
… root workspace. These tests pass when run directly via the server package.
danielnaab
force-pushed
the
child-rendering-refactor
branch
from
7de568d to
bfb5e40
Compare
…th the current version of the code.
danielnaab
force-pushed
the
child-rendering-refactor
branch
from
b7f28ac to
b644328
Compare
…he Vitest workspace covers these tests now.
danielnaab
commented
Jan 10, 2025
|
|
||
| // Press the spacebar to exit reordering mode | ||
| await userEvent.type(grabber, ' '); | ||
| await new Promise(r => setTimeout(r, 100)); | ||
| await new Promise(r => setTimeout(r, 1000)); |
There was a problem hiding this comment.
I really didn't want to update these, but couldn't find a better way to get the tests to pass.
danielnaab
commented
Jan 10, 2025
| @@ -15,7 +15,7 @@ | |||
| "format": "prettier --write \"packages/*/src/**/*.{js,jsx,ts,tsx,scss,css}\"", | |||
| "lint": "turbo run lint", | |||
| "pages": "rm -rf node_modules && npm i -g pnpm turbo && pnpm i && pnpm build && ln -sf ./apps/spotlight/dist _site", | |||
| "test": "vitest run && pnpm --filter @atj/design test:ci", | |||
There was a problem hiding this comment.
The vitest.workspace.ts now includes these tests.
danielnaab
commented
Jan 10, 2025
| "import": "./dist/esm/index.js", | ||
| "require": "./dist/cjs/index.js", | ||
| "types": "./dist/types/index.d.ts" | ||
| "require": "./dist/cjs/index.js" |
There was a problem hiding this comment.
The order of these keys became relevant with node 22.
danielnaab
commented
Jan 10, 2025
| @@ -5,8 +5,8 @@ import commonjs from '@rollup/plugin-commonjs'; | |||
| import json from '@rollup/plugin-json'; | |||
| import typescript from 'rollup-plugin-typescript2'; | |||
|
|
|||
| import packageJson from './package.json' assert { type: 'json' }; | |||
| import workspacePackageJson from '../../package.json' assert { type: 'json' }; | |||
| import packageJson from './package.json' with { type: 'json' }; | |||
There was a problem hiding this comment.
For node.js 22 compatibility
danielnaab
commented
Jan 10, 2025
| @@ -18,6 +18,7 @@ const config: StorybookConfig = { | |||
| getAbsolutePath('@storybook/addon-interactions'), | |||
| getAbsolutePath('@storybook/addon-a11y'), | |||
| getAbsolutePath('@storybook/addon-coverage'), | |||
| getAbsolutePath('@storybook/experimental-addon-test'), | |||
There was a problem hiding this comment.
This will hopefully come out of "experimental" status soon, but seems to be running pretty smoothly now.
danielnaab
commented
Jan 10, 2025
| @@ -12,8 +13,7 @@ const Fieldset: PatternComponent<FieldsetProps> = props => { | |||
| {props.legend} | |||
| </legend> | |||
| )} | |||
|
|
|||
| {props.children} | |||
| {renderPromptComponents(props.context, props.childComponents)} | |||
There was a problem hiding this comment.
All the components that have children have been updated to call a function to render the child prompt component parts. This will enable rendering components with alternate preview props in the edit UI, which will be necessary for the logic UI.
kalasgarov
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #359, handle wrapping PromptComponent objects with React components in the component itself, rather than in the form mechanics.
A number of issues were encountered while updating this, which led to upgrading several dependencies, including Vite, Vitest, and Storybook. This enabled removing JSDOM usage from the Storybook tests and the
describeStoriesusage in favor of Storybook new "experimental" usage of Vitest browser mode. Additionally, node.js was updated to the current-latest LTS, v22.12.0.