Use live API on cloud.gov for parsing #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmoffet
commented
Apr 2, 2024
| @@ -104,31 +104,35 @@ const createPatternPreviewComponent = ( | |||
| ? 'form-group-row field-selected' | |||
| : 'form-group-row'; | |||
|
|
|||
| const editButton = pattern.type === 'input' ? ( | |||
There was a problem hiding this comment.
Only show the edit button if it's an input, skip for purely presentational elements.
There was a problem hiding this comment.
I updated to hide when there is no edit component for the pattern defined.
jimmoffet
commented
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing now fires for all pdfs using the cloud.gov parser instead of a hard-coded cache 🎉
There's a few hundred millisecond delay because the API server is making an external API call to guess the title and produce a description. A good next step would be to split parsing into one endpoint and title/description auto-suggest into another (parsing alone is v fast).
Works reasonably well for AL Name Change. Parsing API needs be tested against a variety of pdfs, there be dragons 🐉 🐲 etc...
Also, removed the input edit button non-input elements.