-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cf ssh needs a PATH, add yum for RedHat #10
Conversation
@@ -117,10 +117,12 @@ install_dependencies () { | |||
# Of course, RedHat/UBI will need more help to add RPM repos with the correct | |||
# version. TODO - RedHat support | |||
echo "[cf-driver] Ensuring git, git-lfs, and curl are installed" | |||
cf ssh "$container_id" -c '(which git && which git-lfs && which curl) || \ | |||
cf ssh "$container_id" --request-pseudo-tty \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: what's the pseudo-tty's purpose here?
I do remember you had an issue when you were trying locally and this seemed to have an impact, but w/ the runner it doesn't make a difference for me as far as I can tell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the request
bit is actually being denied. I don't know that for sure, but when I try force...
instead it just hangs.
|
This bit is loading a set of scripts on the runner into the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
0d7f7fa
to
b224e96
Compare
This may address #9.
We should probably test by having Alpine, Debian and RedHat based worker images run, but that will be a later issue