-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push, Pull, Build, Bop Images #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job getting this over the line!
@@ -27,16 +28,55 @@ create_temporary_varfile () { | |||
echo "[cf-driver] [DEBUG] Added $(wc -l "$TMPVARFILE") lines to $TMPVARFILE" | |||
} | |||
|
|||
get_registry_credentials () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Painful but pragmatic! (Which is probably the rightful title of a Bash book.)
@@ -12,6 +12,7 @@ trap 'rm -f "$TMPVARFILE"' EXIT | |||
currentDir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" | |||
source "${currentDir}/base.sh" # Get variables from base. | |||
if [ -z "${WORKER_MEMORY-}" ]; then | |||
# Some jobs may fail with less than 512M, e.g., `npm i` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: The default is arbitrary - Worth adjusting if we find it is too little in many more cases.
174ad83
to
3f2a7e3
Compare
The changes made to support the Kaniko service workflow are very moderate on the runner side, and mostly depend on the user doing some ugly stuff in their job. I figure we'll want to abstract some of this away for them at some point, but it probably makes more sense to do that after / during a rewrite (see #25 for details and a walkthrough of the script steps).
Closes #16
Closes #17
Closes #21
Closes #22