Add CI_SERVICE_alias environment variables to make referencing the FQDN of services fun! #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`config.sh` prints JSON to STDOUT following the expected form defined in https://docs.gitlab.com/runner/executors/custom.html#config This change also moves `base.sh` warnings to STDERR.
Much ado about little here. Some restructuring was needed in order to populate a CI_SERVICE_<alias> variables as services are started, then inject them into a temporary manifest. On the way I found that the old TMPVARFILE was not working correctly. I 🪿 love 🪿 bash🪿!!!
|
Pipeline proof of life for folks who want "evidence" - https://gitlab.com/pauldoomgov/hyperloop-traffic-jam/-/pipelines/1399063314 |
zjrgov
approved these changes
Aug 5, 2024
| cat "${currentDir}/worker-manifest.yml" > "$TMPMANIFEST" | ||
|
|
||
| # Align additional environment variables with YAML at end of source manifest | ||
| local padding=" " |
Comment on lines
+13
to
+18
| echo "WARNING: DEFAULT_JOB_IMAGE not set! Falling back to ${DEFAULT_JOB_IMAGE}" 1>&2 | ||
| fi | ||
|
|
||
| # Complain if no Docker Hub credentials so we aren't bad neighbors | ||
| if [ -z "$DOCKER_HUB_USER" ] || [ -z "$DOCKER_HUB_TOKEN" ]; then | ||
| echo "WARNING: Docker Hub credentials not set! Falling back to public access which could result in rate limiting." | ||
| echo "WARNING: Docker Hub credentials not set! Falling back to public access which could result in rate limiting." 1>&2 |
Comment on lines
+56
to
+59
| # Add any CI_SERVICE_x variables populated by start_service() | ||
| for v in "${!CI_SERVICE_@}"; do | ||
| echo "${padding}${v}: \"${!v}\"" >> "$TMPMANIFEST" | ||
| done |
There was a problem hiding this comment.
praise: the indirection is pretty nifty, I haven't used that before
zjrgov
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #7
This change injects an environment variable named
CI_SERVICE_<alias>for each service and sets the value to the fully qualified domain name of the service. Here is an example snippet of.gitlab-ci.ymlshowing its use:The old method to get to the same outcome required cobbling the variable together from 5 other variables.
Instead of attempting to hack the GitLab generated command list, we just calculate and inject the CI_SERVICE_alias variables in
prepare.shusing a modified CloudFoundry manifest. It might be hideous, but since the need to calculate a service name dynamically is not present in Docker, Kubernetes, and other executors with ephemeral local network namespaces, it seems right.