Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify pull request approval by engineering #524

Merged
merged 2 commits into from
Mar 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions _articles/pull-request-review.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,22 @@ changes from outside.

[github-repositories]: {% link _articles/github.md %}#repositories

- **Who merges**: once there is at least one approving review, the author
merges their own pull request.
- **Who reviews**: at least one member of the engineering team must review and
approve a pull request before it can be merged.

- In general, any single approving review from another [`18f/identity-core`][github-permissions]
member is adequate. However, in some repositories with default reviewer
groups (such as [identity-dashboard](https://github.com/18f/identity-dashboard)
or [identity-dev-docs](https://github.com/GSA-TTS/identity-dev-docs) with
clear owners) it is preferred to wait for a reviewer from those groups
before merging.

- **Who merges**: the author merges their own pull request.

- In rare circumstances where a merge is time-sensitive and the pull request
author is unavailable, it may be acceptable for another to merge on their
behalf.

- **Who reviews**: in general, any single approving review from another
[`18f/identity-core`][github-permissions] member is adequate.

- However, in some repositories with default reviewer groups
(such as [identity-dashboard](https://github.com/18f/identity-dashboard) or
[identity-dev-docs](https://github.com/GSA-TTS/identity-dev-docs) with clear
owners) it is preferred to wait for a reviewer from those groups before
merging.

[github-permissions]: {% link _articles/github.md %}#permissions

## External Contributions
Expand Down
Loading